Skip to content

Building for desktop shouldn't require a RID #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ericstj opened this issue Jan 26, 2017 · 5 comments
Closed

Building for desktop shouldn't require a RID #730

ericstj opened this issue Jan 26, 2017 · 5 comments

Comments

@ericstj
Copy link
Member

ericstj commented Jan 26, 2017 •
edited
Loading

When I build for desktop I see

f:\cli\latest\sdk\1.0.0-rc4-004530\Sdks\Microsoft.NET.Sdk\build\Microsoft.NET.RuntimeIdentifierInference.targets(49,5): error : RuntimeIdentifier must be set for .NETFramework executables. Consider RuntimeIdentifier=win7-x86 or RuntimeIdentifier=win7-x64.

Why do we force folks to specify a RID? We should be able to restore and build just fine without a RID for desktop. That's the precedent set by NuGet 2. At the very least we should probably be just assuming some RID for desktop if the user hasn't specified one. Forcing it in the project file is busted.
@333fred
Copy link
Member

333fred commented Jan 26, 2017

Dupe of dotnet/project-system#1333.

@333fred 333fred closed this as completed Jan 26, 2017
@ericstj
Copy link
Member Author

ericstj commented Jan 26, 2017

That's fair, but the targets live here so I thought this would be the place to file the issue. https://github.com/dotnet/sdk/blob/master/src/Tasks/Microsoft.NET.Build.Tasks/build/Microsoft.NET.RuntimeIdentifierInference.targets
/cc @nguerrera @dsplaisted

@dsplaisted dsplaisted reopened this Jan 26, 2017
@dsplaisted dsplaisted mentioned this issue Jan 26, 2017
Closed
@srivatsn
Copy link
Contributor

Both are dupes to another issue in the SDK - #357 :)

@ericstj
Copy link
Member Author

ericstj commented Jan 26, 2017

Thanks @srivatsn

@ericstj
Copy link
Member Author

ericstj commented Jan 26, 2017

Ha, and that one is a dup of #396

mmitche pushed a commit to mmitche/sdk that referenced this issue Jun 5, 2020
@vijayrkn
Merge pull request dotnet#730 from aspnet/darc-master-ada62cd4-4290-4…
8a0adbb 
…262-bac8-b3ef94ce2a99

[master] Update dependencies from dotnet/arcade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@srivatsn @dsplaisted @333fred @ericstj