Skip to content

Improve default RID selection for .NETFramework exes #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nguerrera opened this issue Feb 8, 2017 · 3 comments
Closed

Improve default RID selection for .NETFramework exes #840

nguerrera opened this issue Feb 8, 2017 · 3 comments
Labels
Bug needs design
Milestone
Backlog

Comments

@nguerrera
Copy link
Contributor

nguerrera commented Feb 8, 2017 •
edited
Loading

We currently pick win7-x86 or win7-x64 (depending on PlatformTarget) when building on Windows. We should make this more dynamic based on host OS, particularly when we support building net4x applications for non-Windows using Mono.

There are too many uses of $(RuntimeIdentifier) and $(RuntimeIdentifers) in static evaluation context for us to simply run some code to pick a RID.

Possible fixes:

  1. msbuild sets the host rid
  2. nuget uses/returns host rid as part of restore data
  3. things are refactored such that the rid is not needed statically
@nguerrera nguerrera self-assigned this Feb 8, 2017
@nguerrera nguerrera mentioned this issue Feb 9, 2017
Merged
@srivatsn srivatsn added the Bug label Feb 13, 2017
@srivatsn srivatsn added this to the 1.1 milestone Feb 13, 2017
@dsplaisted dsplaisted modified the milestones: 2.0, 1.1 May 15, 2017
@livarcocc livarcocc modified the milestones: 2.0.0, 2.1.0 May 27, 2017
@livarcocc
Copy link
Contributor

@dsplaisted do we need this for the nuget reference assemblies work you are doing? Or is it ok to move this issue?

@dsplaisted
Copy link
Member

@livarcocc This shouldn't be directly related to making reference assemblies available as NuGet packages. You can move it out.

@livarcocc livarcocc modified the milestones: 2.1.3xx, 2.1.4xx Mar 29, 2018
@livarcocc livarcocc modified the milestones: 2.1.4xx, 2.2.1xx Jun 27, 2018
@livarcocc livarcocc modified the milestones: 2.2.1xx, 3.0.1xx Jun 12, 2019
@nguerrera nguerrera modified the milestones: 3.0.1xx, Backlog Jul 23, 2019
@nguerrera nguerrera removed their assignment Jul 23, 2019
@nguerrera
Copy link
Contributor Author

I don't think we should do this. I think we can leave .NET Framework alone. The RID inference is complicated enough there.

mmitche pushed a commit to mmitche/sdk that referenced this issue Jun 5, 2020
@dotnet-maestro
Update dependencies from https://github.com/aspnet/AspNetCore build 2…
a789e7c 
…0190803.5 (dotnet#840)

- Microsoft.AspNetCore.Mvc.Analyzers - 3.0.0-preview9.19403.5
- Microsoft.AspNetCore.Mvc.Api.Analyzers - 3.0.0-preview9.19403.5
- Microsoft.AspNetCore.Analyzers - 3.0.0-preview9.19403.5
- Microsoft.AspNetCore.Components.Analyzers - 3.0.0-preview9.19403.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug needs design
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@srivatsn @nguerrera @dsplaisted @livarcocc