-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Update .editorconfig #12865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update .editorconfig #12865
Conversation
|
This is the same as the one in dotnet runtime? |
Yes, Only changed the header template (in the second commit) to match the one used here. |
| [*] | ||
| insert_final_newline = true | ||
| indent_style = space | ||
| indent_size = 4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a forgotten file extension isn't included in .editorconfig, it may use indent_size = 4 by mistake. I think it makes more sense to move this option to .cs and .vb files only.
For example, the .editorconfig existed before this PR didn't include yml extensions. So, it will use 4 spaces by default, where it should use only 2.
It's more robust to set it only to cs and vb.
|
@Youssef1313 I'll take this change after you revert trim_trailing_whitespace change, since you put a lot thought into. However, it is better to change the file in dotnet/runtime too. Since we don't really want to make a separate style for dotnet/sdk. The next time we sync the file with dotnet/runtime would remove all the special change you made this time. |
Co-authored-by: Sam Harwell <[email protected]>
I opened a discussion in dotnet/runtime. |
This update matches the current dotnet/runtime .editorconfig file. I'll point to the most obvious problems that was in the .editorconfig here.