Skip to content

Conversation

@Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Aug 11, 2020

This update matches the current dotnet/runtime .editorconfig file. I'll point to the most obvious problems that was in the .editorconfig here.

@wli3
Copy link

wli3 commented Aug 11, 2020

This is the same as the one in dotnet runtime?

@Youssef1313
Copy link
Member Author

This is the same as the one in dotnet runtime?

Yes, Only changed the header template (in the second commit) to match the one used here.

[*]
insert_final_newline = true
indent_style = space
indent_size = 4
Copy link
Member Author

@Youssef1313 Youssef1313 Aug 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a forgotten file extension isn't included in .editorconfig, it may use indent_size = 4 by mistake. I think it makes more sense to move this option to .cs and .vb files only.

For example, the .editorconfig existed before this PR didn't include yml extensions. So, it will use 4 spaces by default, where it should use only 2.

It's more robust to set it only to cs and vb.

@wli3
Copy link

wli3 commented Aug 12, 2020

@Youssef1313 I'll take this change after you revert trim_trailing_whitespace change, since you put a lot thought into. However, it is better to change the file in dotnet/runtime too. Since we don't really want to make a separate style for dotnet/sdk. The next time we sync the file with dotnet/runtime would remove all the special change you made this time.

@Youssef1313
Copy link
Member Author

it is better to change the file in dotnet/runtime too.

I opened a discussion in dotnet/runtime.

@wli3 wli3 merged commit 148f0ad into dotnet:master Aug 13, 2020
@Youssef1313 Youssef1313 deleted the patch-3 branch August 13, 2020 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants