Generate errors when referencing an Executable project with different SelfContained value #15134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wli3
approved these changes
Jan 7, 2021
| <UsingTask TaskName="ValidateExecutableReferences" AssemblyFile="$(MicrosoftNETBuildTasksAssembly)" /> | ||
|
|
||
| <Target Name="ValidateExecutableReferences" | ||
| AfterTargets="_GetProjectReferenceTargetFrameworkProperties" |
There was a problem hiding this comment.
No, DependsOnTargets and AfterTargets mean different things: https://github.com/MicrosoftDocs/visualstudio-docs/issues/2994#issuecomment-480017831
Forgind
pushed a commit
to dotnet/msbuild
that referenced
this pull request
Feb 3, 2021
…jects (#5994) This allows additional properties to be gathered from project references via the project reference protocol. This is in order to support generating an error when a self-contained Executable references a non-SelfContained Executable, or vice versa, as described in dotnet/sdk#15117. The referenced project can declare what additional properties should be gathered with AdditionalTargetFrameworkInfoProperty items: <ItemGroup> <AdditionalTargetFrameworkInfoProperty Include="SelfContained"/> <AdditionalTargetFrameworkInfoProperty Include="_IsExecutable"/> </ItemGroup> These items will then be included in the AdditionalPropertiesFromProject metadata on the _MSBuildProjectReferenceExistent items. This value will have PropertyName=PropertyValue combinations joined by semicolons, and those sets of properties for the different TargetFramework values will be joined by double semicolons. For example, a project multitargeted to two TargetFrameworks may have the following for the AdditionalPropertiesFromProject metadata: SelfContained=true;_IsExecutable=true;;SelfContained=false;_IsExecutable=true Finding the right set of properties from the referenced project will required looking up the index of the NearestTargetFramework in the TargetFrameworks, and using that index to select the set of properties in the AdditionalPropertiesFromProject metadata. For example: string nearestTargetFramework = project.GetMetadata("NearestTargetFramework"); int targetFrameworkIndex = project.GetMetadata("TargetFrameworks").Split(';').ToList().IndexOf(nearestTargetFramework); string projectAdditionalPropertiesMetadata = project.GetMetadata("AdditionalPropertiesFromProject").Split(new[] { ";;" }, StringSplitOptions.None)[targetFrameworkIndex]; Dictionary<string, string> projectAdditionalProperties = new(StringComparer.OrdinalIgnoreCase); foreach (var propAndValue in projectAdditionalPropertiesMetadata.Split(';')) { var split = propAndValue.Split('='); projectAdditionalProperties[split[0]] = split[1]; } This is implemented in dotnet/sdk#15134.
|
/azp run |
|
Pull request contains merge conflicts. |
It's automatically handled by MSBuild
dsplaisted
force-pushed
the
exe-reference-selfcontained-mismatch-error
branch
from
5cfe1b0 to
cc7769c
Compare
dsplaisted
force-pushed
the
exe-reference-selfcontained-mismatch-error
branch
from
cc7769c to
f8c33dc
Compare
dsplaisted
added
the
breaking-change
|
@marcpopMSFT @KathleenDollard FYI for breaking change documentation |
10 tasks
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15117
Requires changes to MSBuild in dotnet/msbuild#5994 before this will work.