Skip to content

Use the portable rid for --use-current-runtime. #21748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

tmds
Copy link
Member

@tmds tmds commented Oct 5, 2021

@ghost
Copy link

ghost commented Oct 5, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

Copy link
Member

@dsplaisted dsplaisted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's late enough in the release cycle that I would not put this in 6.0.1xx unless you think it's critical to get it in. I think we can merge it into main now and then backport to 6.0.2xx when we have a branch for that.

@marcpopMSFT marcpopMSFT merged commit 458b5f7 into dotnet:main Oct 6, 2021
@marcpopMSFT
Copy link
Member

marcpopMSFT commented Oct 6, 2021

If you want this included in 6.0.200, please check back in a few weeks when we have the branch open and cherry-pick the change. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--use-current-runtime semantics
3 participants