Update handling of SelfContained and RuntimeIdentifier properties when specified on the command line #21986
Conversation
ghost
added
the
| <AcceptsRuntimeIdentifier Condition="'$(_IsExecutable)' == 'true' Or | ||
| '$(RuntimeIdentifier)' != '' Or | ||
| '$(RuntimeIdentifiers)' != ''">true</AcceptsRuntimeIdentifier> |
There was a problem hiding this comment.
Does this imply that if the project has any RID, we'll flow the RID from the entrypoint? Is that what we want? What if e.g. the entry-point is win11-x64 and the reference is win7-x86? That seems like an OK combination to me . . .
There was a problem hiding this comment.
Yes, we will flow any RID. Most of this is existing logic, ie if RuntimeIdentifier or RuntimeIdentifiers was set in the referenced project, we would have flowed the RID since .NET Core 1.0 I think. The change here is to also flow it if the referenced project is an Exe project, but not if it's a test project.
| @@ -53,6 +55,14 @@ protected override void ExecuteCore() | |||
| bool referencedProjectIsExecutable = MSBuildUtilities.ConvertStringToBool(projectAdditionalProperties["_IsExecutable"]); | |||
| bool referencedProjectIsSelfContained = MSBuildUtilities.ConvertStringToBool(projectAdditionalProperties["SelfContained"]); | |||
|
|
|||
| if (SelfContainedIsGlobalProperty && project.GetBooleanMetadata("AcceptsRuntimeIdentifier") == true) | |||
There was a problem hiding this comment.
Since you need this in a task, use dotnet/msbuild#4939 and avoid the try-overwrite gunk.
|
Folks, FYI: looks like #10566 is related to this. |
dsplaisted
force-pushed
the
selfcontained-flow
branch
from
9e02ff2 to
c81cb50
Compare
dsplaisted
force-pushed
the
selfcontained-flow
branch
from
c81cb50 to
2e1556e
Compare
dsplaisted
force-pushed
the
selfcontained-flow
branch
from
2e1556e to
26df179
Compare
|
|
||
| ## New Behavior | ||
|
|
||
| Both `SelfContained` and `RuntimeIdentifier` will flow a referenced project if any of the following are true for the referenced project: |
There was a problem hiding this comment.
Should that read will flow to a referenced...?
Fixes #7995 Context #6924 changed how IsRidAgnostic works. Normally, the .NET SDK should set the IsRidAgnostic property (added in dotnet/sdk#21986). But when using an older version of the .NET SDK, there is fallback logic in the GetTargetFrameworksWithPlatformForSingleTargetFramework target to replicate the previous logic. However, this fallback logic was incorrect, as it was setting item metadata, but reading from the property to determine whether to set it to the default value. So if the property wasn't set, the IsRidAgnostic metadata would always be false. Testing Manual testing
Fixes #21677
Also changes how the SelfContained and RuntimeIdentifier properties flow between projects when they are specified on the command line. More details are in the comments and the breaking change documentation included in this PR.
This also requires the changes in dotnet/msbuild#6924