Skip to content

Unskip Blazor Integration Tests #22945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 9, 2021

Conversation

TanayParikh
Copy link
Contributor

@TanayParikh TanayParikh commented Dec 7, 2021

Tests were skipped to unblock #22892. The package.json and dotnet.d.ts files were recently added which was causing issues with out baselines. I've filtered those files out as @pavelsavara mentioned they aren't needed.

Fixes: dotnet/aspnetcore#38844

@ghost
Copy link

ghost commented Dec 7, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@TanayParikh TanayParikh added the Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch label Dec 7, 2021
@TanayParikh TanayParikh self-assigned this Dec 7, 2021
@pavelsavara
Copy link
Member

I confirm the files don't belong to wwwroot, so LGTM.
I don't know enough about RazorSDK yet.

@TanayParikh
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@TanayParikh
Copy link
Contributor Author

Going to merge this in so we regain the lost test coverage. I'll follow-up with Pranav or Javier offline once they return to ensure they're fine with the change.

@TanayParikh TanayParikh merged commit d33ef78 into main Dec 9, 2021
@TanayParikh TanayParikh deleted the taparik/blazorSDKFilterPackageJSONAndTypeDef branch December 9, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blazor SDK Targets Packaging Fixes
2 participants