Exe do not inclue app package #2395
Conversation
| } | ||
|
|
||
| [Fact] | ||
| public void Packing_a_netcoreapp_2_0_DotnetCliTool_app_does_not_include_the_implicit_dependency() |
There was a problem hiding this comment.
Remove the "not" from this test name, it's testing the opposite.
|
@Pilchie Do we need any sort of approval to check in to 2.2.1xx? Also FYI this is a breaking change, but we think the impact is low, there is a workaround, and it is worth doing because it fixes a lot of issues. |
| <PackageReference Update="Microsoft.NETCore.App" | ||
| Condition="('$(OutputType)' != 'Exe') And ('$(_TargetFrameworkVersionWithoutV)' != '') And ('$(_TargetFrameworkVersionWithoutV)' >= '2.0')" | ||
| Condition="('$(_TargetFrameworkVersionWithoutV)' != '') And ('$(_TargetFrameworkVersionWithoutV)' >= '2.0') And ('$(PackageType)' != 'DotnetCliTool')" |
There was a problem hiding this comment.
Do we want another escape hatch than setting PackageType? What else does that impact?
There was a problem hiding this comment.
I would say we already have another escape hatch: put the following in your project:
<ItemGroup>
<PackageReference Update="Microsoft.NETCore.App" PrivateAssets="None" />
</ItemGroup>There was a problem hiding this comment.
Good point. I'm convinced. :)
|
I think 2.2.1xx is fair game for now (with signoff, etc) |
|
Test failed due to project tools test assert don't have PackageType property I believe to be valid project tool, you need to set that package type. So I added it to the test asset |
…soft.NETCore.App
Fix #2204 (comment)