Support FrameworkReference items #2486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transform them into targeting pack references and frameworks in runtimeconfig based on KnownFrameworkReference items
Pilchie
reviewed
Aug 22, 2018
| @@ -51,6 +51,7 @@ public class GivenADependencyContextBuilder | |||
| FrameworkConstants.CommonFrameworks.NetCoreApp10, | |||
| runtime, | |||
| Constants.DefaultPlatformLibrary, | |||
| null, | |||
There was a problem hiding this comment.
Nit: suggest using a named param for the literal as for isSelfContained:
|
@dotnet-bot test this please |
|
@dotnet-bot test Windows_NT Release |
livarcocc
reviewed
Aug 22, 2018
| } | ||
| } | ||
|
|
||
| public class ReportUnknownFrameworkReferences : TaskBase |
There was a problem hiding this comment.
Why not put this in its own file?
livarcocc
approved these changes
Aug 22, 2018
peterhuene
reviewed
Aug 22, 2018
| if (platformLibrary != null) | ||
| runtimeOptions.tfm = TargetFramework; | ||
|
|
||
| if (projectContext.RuntimeFrameworks == null) |
There was a problem hiding this comment.
Can the array be zero-length? I forget what MSBuild does with empty items.
peterhuene
approved these changes
Aug 22, 2018
|
@dotnet-bot test Windows_NT Release |
This was referenced Aug 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add target which transforms
FrameworkReferenceitems into implicit NuGet package references (for the corresponding targeting packs) as well as entries in the runtimeconfig.json.Multiple shared frameworks are supported per the design for .NET Core 3.0 specified here.
@livarcocc @peterhuene @steveharter for review