[main] Update dependencies from dotnet/runtime #24985

dotnet-maestro · 2022-04-21T12:35:43Z

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

Subscription: aa69f164-2492-460a-3914-08d8e9750bf8
Build: 20220424.3
Date Produced: April 25, 2022 5:42:24 AM UTC
Commit: 47d9c43ab1f10a98a348a28b3fd7ed9c4d35328b
Branch: refs/heads/main

Updates:
- Microsoft.NETCore.App.Runtime.win-x64: from 7.0.0-preview.4.22219.9 to 7.0.0-preview.5.22224.3
- Microsoft.NETCore.DotNetHostResolver: from 7.0.0-preview.4.22219.9 to 7.0.0-preview.5.22224.3
- Microsoft.NETCore.Platforms: from 7.0.0-preview.4.22219.9 to 7.0.0-preview.5.22224.3
- System.Reflection.MetadataLoadContext: from 7.0.0-preview.4.22219.9 to 7.0.0-preview.5.22224.3
- System.Resources.Extensions: from 7.0.0-preview.4.22219.9 to 7.0.0-preview.5.22224.3
- System.Text.Encoding.CodePages: from 7.0.0-preview.4.22219.9 to 7.0.0-preview.5.22224.3
- System.Security.Cryptography.ProtectedData: from 7.0.0-preview.4.22219.9 to 7.0.0-preview.5.22224.3
- System.CodeDom: from 7.0.0-preview.4.22219.9 to 7.0.0-preview.5.22224.3
- Microsoft.NET.HostModel: from 7.0.0-preview.4.22219.9 to 7.0.0-preview.5.22224.3
- Microsoft.DotNet.ILCompiler: from 7.0.0-preview.4.22219.9 to 7.0.0-preview.5.22224.3
- Microsoft.Extensions.DependencyModel: from 7.0.0-preview.4.22219.9 to 7.0.0-preview.5.22224.3
- Microsoft.NETCore.App.Host.win-x64: from 7.0.0-preview.4.22219.9 to 7.0.0-preview.5.22224.3
- Microsoft.NETCore.App.Ref: from 7.0.0-preview.4.22219.9 to 7.0.0-preview.5.22224.3
- VS.Redist.Common.NetCore.TargetingPack.x64.7.0: from 7.0.0-preview.4.22219.9 to 7.0.0-preview.5.22224.3
- VS.Redist.Common.NetCore.SharedFramework.x64.7.0: from 7.0.0-preview.4.22219.9 to 7.0.0-preview.5.22224.3

…0420.8 Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Text.Encoding.CodePages , System.Security.Cryptography.ProtectedData , System.CodeDom , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , VS.Redist.Common.NetCore.TargetingPack.x64.7.0 , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 From Version 7.0.0-preview.4.22219.9 -> To Version 7.0.0-preview.5.22220.8

dotnet-maestro · 2022-04-21T13:21:15Z

Notification for subscribed users from https://github.com/dotnet/runtime:

@dnr-codeflow

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
For more details, please read the Arcade Darc documentation

…0422.1 Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Text.Encoding.CodePages , System.Security.Cryptography.ProtectedData , System.CodeDom , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , VS.Redist.Common.NetCore.TargetingPack.x64.7.0 , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 From Version 7.0.0-preview.4.22219.9 -> To Version 7.0.0-preview.5.22222.1

…0423.6 Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Text.Encoding.CodePages , System.Security.Cryptography.ProtectedData , System.CodeDom , Microsoft.NET.HostModel , Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , VS.Redist.Common.NetCore.TargetingPack.x64.7.0 , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 From Version 7.0.0-preview.4.22219.9 -> To Version 7.0.0-preview.5.22223.6

kasperk81 · 2022-04-25T09:48:13Z

@marek-safar could you merge main branch again?

@mmitche, @marcpopMSFT, @danmoseley. i can only comment on what i have seen as an outsider. this is a request for action.

flaky tests has slowed down code flow. there is a 99% of chance that one or more checks will fail in dotnet-maestro PRs, then someone will manually rerun the check from portal to make it "look" green and merge. eveyone is interested in just getting their stuff through and nobody has time or interest to actually go ahead fix these tests. the success rate of this pipeline is under water: https://dev.azure.com/dnceng/public/_pipeline/analytics/stageawareoutcome?definitionId=136&contextType=build

these tests were flaky two years ago and they are flaky today. there has been enough reminders and notifications, and enough time has been wasted by people who can't do anything about it. best thing to do now, imo, is disable all flaky tests in sdk and installer repos to unblock auto code flow. when somebody will find time to fix the tests (maybe this year or the next or never), they should enable them back.

…0424.3 Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Text.Encoding.CodePages , System.Security.Cryptography.ProtectedData , System.CodeDom , Microsoft.NET.HostModel , Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , VS.Redist.Common.NetCore.TargetingPack.x64.7.0 , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 From Version 7.0.0-preview.4.22219.9 -> To Version 7.0.0-preview.5.22224.3

marcpopMSFT · 2022-04-25T16:49:30Z

@kasperk81
CC @mmitche @marek-safar @danmoseley

You are right. We've gone from single digit test instability in the fall to low double digits in Jan to even higher now and that's not sustainable. The efforts to improve test stability includes the following items that I'm tracking. Let me know if you're aware of more improvements we can make or if anyone has capacity to help.

95b6a4a
Update the wasm install to skip manifest updates #24958
Allow file changes from tar as it's just a warning #24971
Fix unstable test build #24592
Update ubuntu version #24650
- The runtime occassionally crashes on 18 Ubuntu and they don't plan to resolve given the crash rate is low.
Next set of three test projects to move to Helix. #23975
- Helix and non-helix builds run in parallel but are running into each other (see Fix unstable test build #24592 and Allow file changes from tar as it's just a warning #24971 as examples of this). We need to get the last set of tests moved to helix but that's going to be very difficult as dotnet-test has over 1k tests and was never meant to run in helix.
SDK tests download over 2k nuget packages. When we run too many PRs in parallel, we get throttled by various feeds that host these packages. We're trying to zip these up so we can pre-download them into the nuget cache.

I went ahead and created an Epic to track this work: #25044

marek-safar · 2022-04-25T17:59:37Z

@marcpopMSFT I see this failure a lot

Unhandled exception: System.UnauthorizedAccessException: Access to the path '/Users/helix-runner/.templateengine/dotnetcli/v7.0.100-ci' is denied.
 ---> System.IO.IOException: Permission denied
   --- End of inner exception stack trace ---
   at System.IO.FileSystem.CreateDirectory(String fullPath)
   at System.IO.Directory.CreateDirectory(String path)
   at Microsoft.TemplateEngine.Utils.PhysicalFileSystem.CreateDirectory(String path)
   at Microsoft.TemplateEngine.Edge.EngineEnvironmentSettings..ctor(ITemplateEngineHost host, Boolean virtualizeSettings, String settingsLocation, IEnvironment environment, IComponentManager componentManager, IPathInfo pathInfo)
   at Microsoft.TemplateEngine.Cli.Commands.BaseCommand.CreateEnvironmentSettings(GlobalArgs args, ParseResult parseResult)
   at Microsoft.TemplateEngine.Cli.Commands.BaseCommand`1.InvokeAsync(InvocationContext context)
   at Microsoft.TemplateEngine.Cli.Commands.BaseCommand`1.Invoke(InvocationContext context)

which of the issues is tracking it?

kasperk81 · 2022-04-25T21:02:36Z

all commits that bot is updating right now dotnet/runtime@e3442b4...47d9c43

failing test:

Microsoft.NET.Build.Tests.GivenThatWeWantToUseAnalyzers.It_resolves_analyzers_correctly(language: "C#", testAssetName: "AppWithLibrary") [FAIL]
Expected collection

{(Microsoft.NET.Sdk, , analyzers/Microsoft.CodeAnalysis.CSharp.NetAnalyzers.dll), (Microsoft.NET.Sdk, , analyzers/Microsoft.CodeAnalysis.NetAnalyzers.dll), (microsoft.codequality.analyzers, 2.6.0, analyzers/dotnet/cs/Microsoft.CodeQuality.Analyzers.dll), (microsoft.codequality.analyzers, 2.6.0, analyzers/dotnet/cs/Microsoft.CodeQuality.CSharp.Analyzers.dll), (microsoft.dependencyvalidation.analyzers, 0.9.0, analyzers/dotnet/Microsoft.DependencyValidation.Analyzers.dll), (microsoft.netcore.app.ref, , analyzers/dotnet/Microsoft.Interop.LibraryImportGenerator.dll), (microsoft.netcore.app.ref, , analyzers/dotnet/Microsoft.Interop.SourceGeneration.dll), (microsoft.netcore.app.ref, , analyzers/dotnet/cs/System.Text.Json.SourceGeneration.dll), (microsoft.netcore.app.ref, , analyzers/dotnet/cs/System.Text.RegularExpressions.Generator.dll)}

to be equivalent to

{(Microsoft.NET.Sdk, , analyzers/Microsoft.CodeAnalysis.CSharp.NetAnalyzers.dll), (Microsoft.NET.Sdk, , analyzers/Microsoft.CodeAnalysis.NetAnalyzers.dll), (microsoft.netcore.app.ref, , analyzers/dotnet/cs/System.Text.Json.SourceGeneration.dll), (microsoft.netcore.app.ref, , analyzers/dotnet/cs/System.Text.RegularExpressions.Generator.dll), (microsoft.codequality.analyzers, 2.6.0, analyzers/dotnet/cs/Microsoft.CodeQuality.Analyzers.dll), (microsoft.codequality.analyzers, 2.6.0, analyzers/dotnet/cs/Microsoft.CodeQuality.CSharp.Analyzers.dll), (microsoft.dependencyvalidation.analyzers, 0.9.0, analyzers/dotnet/Microsoft.DependencyValidation.Analyzers.dll)}

but it contains too many items.

is due to dotnet/runtime@677f6e5.

needs this line

                        ("microsoft.netcore.app.ref", (string)null, "analyzers/dotnet/Microsoft.Interop.LibraryImportGenerator.dll"),
                        ("microsoft.netcore.app.ref", (string)null, "analyzers/dotnet/Microsoft.Interop.SourceGeneration.dll"),

after

sdk/src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToUseAnalyzers.cs

Line 72 in de390be

    
           ("microsoft.dependencyvalidation.analyzers", "0.9.0", "analyzers/dotnet/Microsoft.DependencyValidation.Analyzers.dll")

@elinor-fung there are two new files for interop generator. is this expected?

elinor-fung · 2022-04-25T21:49:34Z

Thanks @kasperk81. Yes, those are expected new files for the interop generator. I pushed an update to the test.

kasperk81 · 2022-04-25T22:42:23Z

thanks!
next up:

Microsoft.NET.Sdk.BlazorWebAssembly.Tests.WasmJsModulesIntegrationTests.Build_DoesNotGenerateManifestJson_IncludesJSModulesOnBlazorBootJsonManifest [FAIL]
      Expected subject to be a collection with 404 item(s), but found 406.

it happened at least once before: #22892 (comment)

cc @TanayParikh, @pavelsavara i think it is blocked on #25045, which in turn is blocked on #24971. not to mention this pr will presumeably unblock dotnet/installer#13659 (i.e. the first ~~daily~~ build of dotnet sdk with NativeAOT support)

TanayParikh · 2022-04-25T23:02:31Z

That error should be resolved via #25049.

kasperk81 · 2022-04-25T23:42:30Z

cool. that is merged to main, so we need to just merge main in pr branch.

kasperk81 · 2022-04-25T23:48:56Z

actually target branch of #25049 wasdarc-release/7.0.1xx-preview4-bd2fbb86-407c-4281-9017-a5e5e5ed4cdb. so it needs more work to get that to main?

TanayParikh · 2022-04-25T23:53:49Z

actually target branch of #25049 wasdarc-release/7.0.1xx-preview4-bd2fbb86-407c-4281-9017-a5e5e5ed4cdb. so it needs more work to get that to main?

Yeah, we can probably cherry-pick the commit into main. cc/ @MackinnonBuck

MackinnonBuck · 2022-04-26T00:09:51Z

See: #25059

kasperk81 · 2022-04-26T01:17:07Z

See: #25059

that pr is failing with reverse message:

Microsoft.NET.Sdk.BlazorWebAssembly.Tests.WasmJsModulesIntegrationTests.Build_DoesNotGenerateManifestJson_IncludesJSModulesOnBlazorBootJsonManifest [FAIL]
      Expected subject to be a collection with 406 item(s), but found 404.

you'd need to cherry-pick on this pr branch darc-main-218d1a76-5a57-457c-b606-c7f1898b4911 otherwise if you force merge it, it will block the main branch and the prs targetting main until this pr is merged (there maybe more failures to fix here so it can get delayed). please also merge main to this pr in the same step.

(cherry picked from commit 588aa53)

TanayParikh · 2022-04-26T05:48:10Z

Cherry-picked 588aa53 & merged main. Hopefully that does the trick!

ghost added the Area-CodeFlow label Apr 21, 2022

dotnet-maestro bot and others added 3 commits April 22, 2022 12:34

Merge branch 'main' into darc-main-218d1a76-5a57-457c-b606-c7f1898b4911

9d1fb76

marcpopMSFT mentioned this pull request Apr 25, 2022

[main] Update dependencies from dotnet/sdk dotnet/installer#13659

Merged

Update test for new generator

0884c29

MackinnonBuck and others added 2 commits April 26, 2022 05:45

Update baselines.

52c0eba

(cherry picked from commit 588aa53)

Merge branch 'main' into darc-main-218d1a76-5a57-457c-b606-c7f1898b4911

9361eba

dotnet-maestro bot requested review from captainsafia and mkArtakMSFT as code owners April 26, 2022 05:46

TanayParikh mentioned this pull request Apr 26, 2022

Update Blazor static web assets baselines (cherry-pick #25049) #25059

Closed

dotnet-maestro bot merged commit 033dcbc into main Apr 26, 2022

dotnet-maestro bot deleted the darc-main-218d1a76-5a57-457c-b606-c7f1898b4911 branch April 26, 2022 07:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[main] Update dependencies from dotnet/runtime #24985

[main] Update dependencies from dotnet/runtime #24985

Uh oh!

dotnet-maestro bot commented Apr 21, 2022 •

edited

Loading

Uh oh!

dotnet-maestro bot commented Apr 21, 2022

Uh oh!

kasperk81 commented Apr 25, 2022 •

edited

Loading

Uh oh!

marcpopMSFT commented Apr 25, 2022

Uh oh!

marek-safar commented Apr 25, 2022

Uh oh!

kasperk81 commented Apr 25, 2022

Uh oh!

elinor-fung commented Apr 25, 2022

Uh oh!

kasperk81 commented Apr 25, 2022 •

edited

Loading

Uh oh!

TanayParikh commented Apr 25, 2022

Uh oh!

kasperk81 commented Apr 25, 2022

Uh oh!

kasperk81 commented Apr 25, 2022

Uh oh!

TanayParikh commented Apr 25, 2022

Uh oh!

MackinnonBuck commented Apr 26, 2022

Uh oh!

kasperk81 commented Apr 26, 2022

Uh oh!

TanayParikh commented Apr 26, 2022

Uh oh!

Uh oh!

[main] Update dependencies from dotnet/runtime #24985

[main] Update dependencies from dotnet/runtime #24985

Uh oh!

Conversation

dotnet-maestro bot commented Apr 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

From https://github.com/dotnet/runtime

Uh oh!

dotnet-maestro bot commented Apr 21, 2022

Notification for subscribed users from https://github.com/dotnet/runtime:

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

Uh oh!

kasperk81 commented Apr 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marcpopMSFT commented Apr 25, 2022

Uh oh!

marek-safar commented Apr 25, 2022

Uh oh!

kasperk81 commented Apr 25, 2022

Uh oh!

elinor-fung commented Apr 25, 2022

Uh oh!

kasperk81 commented Apr 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TanayParikh commented Apr 25, 2022

Uh oh!

kasperk81 commented Apr 25, 2022

Uh oh!

kasperk81 commented Apr 25, 2022

Uh oh!

TanayParikh commented Apr 25, 2022

Uh oh!

MackinnonBuck commented Apr 26, 2022

Uh oh!

kasperk81 commented Apr 26, 2022

Uh oh!

TanayParikh commented Apr 26, 2022

Uh oh!

Uh oh!

dotnet-maestro bot commented Apr 21, 2022 •

edited

Loading

kasperk81 commented Apr 25, 2022 •

edited

Loading

kasperk81 commented Apr 25, 2022 •

edited

Loading