[release/7.0.4xx] Default all containers to linux instead of the current SDK's OS #32473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
baronfel
added
Area-Containers
MichalPavlik
approved these changes
May 15, 2023
baronfel
changed the title
|
Can it be considered as the breaking change? We recently had some PR implementing Windows containers too. |
|
This is a breaking change coming in dotnet-docker anyway for .NET 8, and container usage is vastly linux-oriented anyway. We can quantify this in telemetry though. |
|
I will also send a docs update PR to sdk-container-builds 👍 |
donJoseLuis
approved these changes
May 15, 2023
| [Theory] | ||
| public void WindowsUsersGetLinuxContainers(string sdkPortableRid, string expectedRid) | ||
| { | ||
| var (project, logger, d) = ProjectInitializer.InitProject(new() |
There was a problem hiding this comment.
very minor: for maintainability, consider a friendlier name than d
| { | ||
| ["TargetFrameworkVersion"] = "v6.0", | ||
| ["NETCoreSdkPortableRuntimeIdentifier"] = sdkPortableRid | ||
| }, projectName: $"{nameof(WindowsUsersGetLinuxContainers)}_{sdkPortableRid}_{expectedRid}"); |
There was a problem hiding this comment.
very minor: though syntax is correct, the code does not feel very csharpie. Feels like some functional program written in c#. A respectful opinion, not a fact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most containers usage is Linux, even on Windows, and so our out-of-the-box defaults should make that pathway easy to use.
This changes the default container RID logic to prefer the Linux RID matching the architecture of the current SDK. This helps us ensure a minimal amount of emulation. Critically, it makes 'normal'
dotnet publishcommands for containers use a more reasonable default - in .NET 8dotnet publish -p PublishProfile=DefaultContainermeans 'a release mode Linux container'.