Infer PlatformTarget from RuntimeIdentifier #326
Conversation
| @@ -0,0 +1,45 @@ | |||
| <!-- | |||
| *********************************************************************************************** | |||
| Microsoft.NET.TargetFrameworkInference.targets | |||
There was a problem hiding this comment.
Wrong name, cut and paste
| return selfContained ? | ||
| Path.Combine("Debug", targetFramework, RuntimeEnvironment.GetRuntimeIdentifier(), PublishSubfolderName) : | ||
| Path.Combine("Debug", targetFramework, PublishSubfolderName); | ||
| if (runtimeIdentifier.Length == 0 && selfContained) |
In what timeframe would you expect to switch to a RID-specific output path? |
Tomorrow if urgent, is it? |
|
Late tonight if even more urgent. I have an appointment from 5-6 PM. |
nguerrera
force-pushed
the
infer-platform-target
branch
from
e50f91e to
1025317
Compare
|
My appointment was canceled. Still working on tests. |
|
Found bugs, don't merge. Will reopen when fixed. |
nguerrera
force-pushed
the
infer-platform-target
branch
from
1025317 to
02c4c32
Compare
|
@srivatsn @eerhardt @dsplaisted @dotnet/project-system Tests added, bugs fixed. Please review. |
Require RID for .NETFramework exes
nguerrera
force-pushed
the
infer-platform-target
branch
from
02c4c32 to
f89608d
Compare
nguerrera
changed the title
|
|
||
| var buildCommand = new BuildCommand(Stage0MSBuild, testAsset.TestRoot); | ||
| buildCommand | ||
| .Execute($"/p:RuntimeIdentifier=win7-x86", "/p:PlatformTarget=x64") |
There was a problem hiding this comment.
Is there ever a case where it would be correct to do this (ie have RuntimeIdentifier be for x86 but PlatformTarget be x64)?
|
|
||
| <When Condition="$(RuntimeIdentifier.EndsWith('-arm')) or $(RuntimeIdentifier.Contains('-arm-'))"> | ||
| <PropertyGroup> | ||
| <PlatformTarget>arm</PlatformTarget> |
There was a problem hiding this comment.
@gkhanna79 did some work to enable arm32. Does that have a different RID/architecture than arm64?
| </Otherwise> | ||
| </Choose> | ||
|
|
||
| <Target Name="CheckRuntimeIdentifier"> |
There was a problem hiding this comment.
Should we put in an "escape hatch" for this Target? Like a property that will shut it off completely if the users really, really knows what they are doing and wants to skip this check.
…hesFor21 Apply source build patches for 2.1
Also, require RID for .NETFramework exes
@srivatsn @eerhardt Working on a test, but given urgency, would be good to get review started in parallel.
Finally, I ran into test issues with redirecting the build output path to have the RID so I reverted that for now. I'm thinking that can wait.