Skip to content

[wasm] Override versions of previous runtime packs #32882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

maraf
Copy link
Member

@maraf maraf commented May 29, 2023

Override value of properties _RuntimePackInWorkloadVersion6 and _RuntimePackInWorkloadVersion7 to match versions in SDK.

Fixes #32864

@maraf maraf added this to the 8.0.1xx milestone May 29, 2023
@maraf maraf requested review from lewing and marcpopMSFT May 29, 2023 08:46
@maraf maraf self-assigned this May 29, 2023
@ghost ghost added the untriaged Request triage from a team member label May 29, 2023
@marcpopMSFT
Copy link
Member

@maraf I think you want to target main with this as preview 5 is closed and we don't have automatic codeflow out of previews. Otherwise it looks good to me.

@marcpopMSFT marcpopMSFT changed the base branch from release/8.0.1xx-preview5 to main June 1, 2023 23:00
@marcpopMSFT marcpopMSFT changed the base branch from main to release/8.0.1xx-preview5 June 1, 2023 23:01
@marcpopMSFT
Copy link
Member

tried changing the base but it brought along other changes so you'll either need a separate PR or a rebase

@maraf maraf force-pushed the WasmRuntimePackVersions branch from 1207527 to d275c92 Compare July 14, 2023 22:04
@maraf maraf changed the base branch from release/8.0.1xx-preview5 to main July 14, 2023 22:04
Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to see a better solution long term but this is fine for the moment

@maraf maraf merged commit bfe468b into dotnet:main Jul 17, 2023
@maraf maraf deleted the WasmRuntimePackVersions branch July 17, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Workloads untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downlevel wasm tests fail on net6.0.x runtime pack download
4 participants