Add test #40548
Merged
Add test #40548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
marcpopMSFT
reviewed
Jun 4, 2024
|
|
||
| var rollback = GetRollback(directory); | ||
|
|
||
| VM.WriteFile("C:\\SdkTesting\\global.json", @"{""sdk"":{""workloadVersion"":""versionToUpdateTo""}}".Replace("versionToUpdateTo", versionToUpdateTo)).Execute().Should().Pass(); |
There was a problem hiding this comment.
nit: is there a way to use the variable inline rather than the clunky replace logic? Just a bit wordy.
There was a problem hiding this comment.
String interpolation is a bit hampered when the string you're creating actually needs { and }. I can try to see if there's an escape sequence for that, though.
marcpopMSFT
approved these changes
Jun 4, 2024
Forgind
commented
Jun 4, 2024
Forgind
commented
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.