Fine tune first join point and VMR support for it #44153

ViktorHofer · 2024-10-14T13:17:47Z

Remove not needed global property from sdk's eng/DotNetBuild.props
Make sure that the job name includes the build pass number
Make the join point vertical not replace the original vertical but be an addtional vertical
Make sure that the DotNetBuildPass property gets passed in globally in the VMR orchestrator, not just for dotnet/sdk (for future join points).
Correctly condition the components to be built on BuildPass=2
Only build repos in the VMR that are marked to be built for that join point
Make it possible to build the VSTemplateLocator component without needing to build the whole sdk again (1min vs ~10min build time)

eng/pipelines/templates/jobs/vmr-build.yml

eng/Build.props

eng/DotNetBuild.props

src/Installer/redist-installer/projects/SdkResolver.csproj

eng/pipelines/templates/jobs/vmr-build.yml

We explicitly don't want empty repo builds and are changing the VMR orchestrator infra in dotnet/sdk#44153 to not trigger such repo builds.

- Remove not needed global property from sdk's eng/DotNetBuild.props - Make sure that the job name includes the build pass number - Make the join point vertical not replace the original vertical but be an addtional vertical - Make sure that the DotNetBuildPass property gets passed in globally in the VMR orchestrator, not just for dotnet/sdk (for future join points). - Correctly condition the components to be built on BuildPass=2

…cals (buildpass>1)

eng/pipelines/templates/stages/vmr-build.yml

ViktorHofer · 2024-10-17T14:49:18Z

So this is ready. As mentioned in the top post, with this PR we now correctly implement a join point build leg that adds artifacts.

Things for follow-up PRs:

Make it possible to build the VS.Redist.Common.Net.Core.SDK.MSBuildExtensions package standalone and correctly sequence it into the existing joint point. (It's not getting produced yet)
Explore ideas how to not upload all the artifacts from the dependent jobs in the join point vertical.

Directory.Build.targets

src/Installer/redist-installer/projects/VSTemplateLocator/VSTemplateLocator.csproj

mmitche · 2024-10-17T15:26:44Z

Merging around checks as just a temp YAML change was reverted.

ViktorHofer requested review from a team as code owners October 14, 2024 13:17

ghost added Area-Infrastructure untriaged Request triage from a team member labels Oct 14, 2024

ViktorHofer commented Oct 14, 2024

View reviewed changes

eng/pipelines/templates/jobs/vmr-build.yml Outdated Show resolved Hide resolved

ViktorHofer mentioned this pull request Oct 14, 2024

Introduce a join point for SdkLocator and VSTemplateLocator #43723

Merged

This was referenced Oct 14, 2024

Failure on Helix tests - Tests timing out #40074

Open

error MSB3231: Unable to remove directory #42963

Closed

Microsoft.NET.Build.Containers.IntegrationTests are pulling from Docker Hub #42026

Open

mmitche reviewed Oct 14, 2024

View reviewed changes

eng/Build.props Show resolved Hide resolved

mmitche reviewed Oct 14, 2024

View reviewed changes

eng/DotNetBuild.props Outdated Show resolved Hide resolved

mmitche reviewed Oct 14, 2024

View reviewed changes

src/Installer/redist-installer/projects/SdkResolver.csproj Show resolved Hide resolved

am11 reviewed Oct 15, 2024

View reviewed changes

eng/pipelines/templates/jobs/vmr-build.yml Show resolved Hide resolved

ViktorHofer force-pushed the BuildPass2Components branch from 3bd18c3 to 08aeff5 Compare October 15, 2024 10:04

ViktorHofer added a commit to dotnet/arcade that referenced this pull request Oct 15, 2024

Don't allow empty repo builds when DotNetBuildPass > 1

5e6e5b2

We explicitly don't want empty repo builds and are changing the VMR orchestrator infra in dotnet/sdk#44153 to not trigger such repo builds.

ViktorHofer mentioned this pull request Oct 15, 2024

Don't allow empty repo builds when DotNetBuildPass > 1 dotnet/arcade#15179

Merged

1 task

ViktorHofer force-pushed the BuildPass2Components branch from 233c07a to 2cafda8 Compare October 15, 2024 15:45

This was referenced Oct 16, 2024

There are no more endpoints available from the endpoint mapper. dotnet/dnceng#3844

Open

Nuget: Central Directory corrupt dotnet/dnceng#3099

Open

ViktorHofer added 11 commits October 16, 2024 10:56

Test join point

c569ce6

Build only repos in the VMR that should be built for join point verti…

91bc040

…cals (buildpass>1)

Update vmr-build.yml

076cc04

Build right assets in buildpass=2

f856cc3

MSI change that was missed

21ef7ff

Correctly build VSTemplateLocator package

ef92119

VSTemplateLocator fix

7f4b0aa

one more vstemplatelocator fix

923aa6e

fix source-build leg

5144584

Change error to condition for dependent projects

3f1a53c

Up- and download the repo asset manifests

2f55617

ViktorHofer force-pushed the BuildPass2Components branch from 67f556e to 2f55617 Compare October 16, 2024 08:56

ViktorHofer added 8 commits October 16, 2024 12:37

some small clean-up

52752eb

Update Directory.Build.props

ff189dd

Don't include vertical manifest when merging manifests

520bd83

Pull down all artifacts when not building from source

c3c194c

Fix VMR orchestration in DotNetBuildPass > 1

3953253

Fix RepositoryReference

fad87d5

Extract tool packages

b1846a8

Don't run tests in the build pass 2 vertical

cecc705

build-analysis bot mentioned this pull request Oct 16, 2024

Test failure - AllWebProjectsRestoreAndBuild fails with Unbalanced Condition for F# MVC templates #40073

Open

ViktorHofer added 4 commits October 17, 2024 00:20

one more fix

6e556ae

Publishing.props and yml fix

70d78a2

yml fix

d855396

Don't copy sdk archive in a join point

44da1cd

ViktorHofer commented Oct 17, 2024

View reviewed changes

eng/pipelines/templates/stages/vmr-build.yml Outdated Show resolved Hide resolved

ViktorHofer mentioned this pull request Oct 17, 2024

Join assets from verticals in the final join point #43627

Merged

mmitche reviewed Oct 17, 2024

View reviewed changes

Directory.Build.targets Show resolved Hide resolved

mmitche reviewed Oct 17, 2024

View reviewed changes

src/Installer/redist-installer/projects/VSTemplateLocator/VSTemplateLocator.csproj Show resolved Hide resolved

mmitche reviewed Oct 17, 2024

View reviewed changes

src/Installer/redist-installer/projects/VSTemplateLocator/VSTemplateLocator.csproj Show resolved Hide resolved

mmitche approved these changes Oct 17, 2024

View reviewed changes

Update eng/pipelines/templates/stages/vmr-build.yml

fe2b6c1

mmitche merged commit 7deb362 into main Oct 17, 2024
3 of 36 checks passed

mmitche deleted the BuildPass2Components branch October 17, 2024 15:26

This was referenced Oct 17, 2024

Checkout failure: "Git fetch failed with exit code 128" dotnet/arcade#9009

Open

Unable to checkout dotnet/dnceng#4115

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fine tune first join point and VMR support for it #44153

Fine tune first join point and VMR support for it #44153

Uh oh!

ViktorHofer commented Oct 14, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ViktorHofer commented Oct 17, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mmitche commented Oct 17, 2024

Uh oh!

Uh oh!

Uh oh!

Fine tune first join point and VMR support for it #44153

Fine tune first join point and VMR support for it #44153

Uh oh!

Conversation

ViktorHofer commented Oct 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ViktorHofer commented Oct 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mmitche commented Oct 17, 2024

Uh oh!

Uh oh!

Uh oh!

ViktorHofer commented Oct 14, 2024 •

edited

Loading

ViktorHofer commented Oct 17, 2024 •

edited

Loading