Skip to content

[main] Update dependencies from dotnet/source-build-reference-packages #45661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Dec 31, 2024

This pull request updates the following dependencies

From https://github.com/dotnet/source-build-reference-packages

  • Subscription: a9c0be9d-1bd0-4d16-ec3f-08db308e7a41
  • Build: 20250106.2
  • Date Produced: January 6, 2025 5:10:05 PM UTC
  • Commit: 72009fb6ce7327430539004be1dcbfb6fb88adab
  • Branch: refs/heads/main

…ence-packages build 20241230.1

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 10.0.561602 -> To Version 10.0.563001
@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Dec 31, 2024
@ViktorHofer
Copy link
Member

@dotnet/source-build PTAL

…ence-packages build 20250106.1

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 10.0.561602 -> To Version 10.0.605601
Uses a version of the tarball with SourceBuildReferencePackages/Microsoft.NETCore.App.Ref.9.0.0.nupkg removed
@mthalman mthalman requested review from a team as code owners January 6, 2025 20:47
@MichaelSimons
Copy link
Member

MichaelSimons commented Jan 6, 2025

There is some non-determinism happening which is why the initial flow passed CI but broke the internal builds. The non-determinism comes from multiple versions of Microsoft.NETCore.App.Ref.9.0.0 in the system (one from n-1 artifacts (SBRP) and one from a SBRP DependencyPackageProject). The version in n-1 artifacts is incorrect and the issue was addressed in dotnet/source-build-reference-packages@e7dfdea. The problem is that it is in very easy to get us out of this situation. To fix this, the package was removed from the n-1 artifacts with 014e0f8.

…ence-packages build 20250106.2

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 10.0.561602 -> To Version 10.0.605602
@ViktorHofer ViktorHofer merged commit f9735a9 into main Jan 7, 2025
38 of 41 checks passed
@ViktorHofer ViktorHofer deleted the darc-main-2c83c476-bd11-4f1f-aa28-f9f0a7523eb4 branch January 7, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-CodeFlow untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants