PGO artifacts are vertical visibility by default except for dotnet-sdk-pgo-* #46063
Conversation
ghost
added
|
/azp run sdk-unified-build-full |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
They're consumed by dotnet-optimization to generate the next set of PGO data to feed back into dotnet/runtime. |
| @@ -95,6 +95,8 @@ | |||
| <BuildArgs>$(BuildArgs) /p:SourceBuiltAssetManifestsDir=$(RepoAssetManifestsDir)</BuildArgs> | |||
| <BuildArgs Condition="'$(OfficialBuildId)' != ''">$(BuildArgs) /p:OfficialBuildId=$(OfficialBuildId)</BuildArgs> | |||
| <BuildArgs Condition="'$(ForceDryRunSigning)' != ''">$(BuildArgs) /p:ForceDryRunSigning=$(ForceDryRunSigning)</BuildArgs> | |||
| <!-- PGO assets by default are "Vertical" visibilty. Each repo will enable the specific artifacts it must publish externally --> | |||
| <BuildArgs Condition="'$(PgoInstrument)' == 'true'">$(BuildArgs) /p:DefaultArtifactVisibility=Vertical</BuildArgs> | |||
There was a problem hiding this comment.
@ViktorHofer @jkoritzinsky Is your thinking that default artifact visibility is something that the VMR will be responsible for passing, rather than runtime setting this under certain conditions?
There was a problem hiding this comment.
I think the default visibility should be a property of the VMR for PGO as we need to tell every repo (not just runtime) that its assets are Vertical-only.
For other scenarios (like filtering out RID-agnostic packages if we wanted to get rid of the concept of a main vertical entirely) I could see runtime controlling the default rules itself.
jkoritzinsky
added
Blocked
|
/azp run sdk-unified-build-full |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
All of the |
jkoritzinsky
force-pushed
the
pgo-visibility-default
branch
from
8fdfa88 to
59cca10
Compare
|
/azp run sdk-unified-build-full |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I don't think we are yet at the point of merging this PR but before doing that, we should queue an official build as only that executes the |
|
/azp run sdk-unified-build-full |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run sdk-unified-build-full |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This PR should now be unblocked as we just merged the SDK re-bootstrap. |
|
Here's an internal official build with the final join from 98a908a: https://dev.azure.com/dnceng/internal/_build/results?buildId=2627132&view=results It still has the toolset packages on Windows and Arcade's packages, but this job shows that we've already handled all of the cases that were causing bad duplicates (duplicates for assets not produced in win-x64 jobs). The rest we can validate by checking the asset manifests of public CI. |
|
/azp run sdk-unified-build-full |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…ard ways (and it was picking up installers in the linux PGO legs)
jkoritzinsky
force-pushed
the
pgo-visibility-default
branch
from
55dc4b3 to
fe24e02
Compare
|
/azp run sdk-unified-build-full |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run sdk-unified-build-full |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run sdk-unified-build-full |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Success! Only the PGO assets are published from the PGO jobs! I'll merge this in |
Blocked on #46021
Contributes to dotnet/source-build#4648