Skip to content

Add VMR step to validate asset baseline #46991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 26, 2025
Merged

Add VMR step to validate asset baseline #46991

merged 4 commits into from
Feb 26, 2025

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Feb 20, 2025

Part of dotnet/source-build#3819, dotnet/source-build#3819.

Adds step to VMR that compares the build output to the output of the dotnet repo builds from each component repository.

Test builds: https://dev.azure.com/dnceng/internal/_build/results?buildId=2647010&view=results, https://dev.azure.com/dnceng/internal/_build/results?buildId=2647009&view=results

@Copilot Copilot AI review requested due to automatic review settings February 20, 2025 20:24
@wtgodbe wtgodbe requested review from a team as code owners February 20, 2025 20:24
@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Feb 20, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

eng/pipelines/templates/stages/vmr-build.yml:952

  • [nitpick] Verify that the conditional variable group block is correctly structured and indented as expected by Azure Pipelines. Inconsistent YAML syntax here could lead to unexpected variable resolution.
- ${{ if eq(variables['System.TeamProject'], 'internal') }}:

@wtgodbe
Copy link
Member Author

wtgodbe commented Feb 21, 2025

@wtgodbe wtgodbe merged commit fbebbf9 into main Feb 26, 2025
34 of 40 checks passed
@wtgodbe wtgodbe deleted the wtgodbe/AssetScripts branch February 26, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants