Skip to content

Fix Microsoft.IO.Redist versions #48819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

marcpopMSFT
Copy link
Member

Add Microsoft.IO.Redist to Directory.packages.props to ensure it's lifted up to a supported version

Upgrade the minimum msbuild which had a 6.0.0 reference

…fted up to a supported version

Upgrade the minimum msbuild which had a 6.0.0 reference
@Copilot Copilot AI review requested due to automatic review settings May 5, 2025 22:35
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (2)
  • Directory.Packages.props: Language not supported
  • eng/Versions.props: Language not supported

@marcpopMSFT marcpopMSFT requested review from a team and vijayrkn as code owners May 6, 2025 22:33
@ericstj
Copy link
Member

ericstj commented May 6, 2025

I think you should adjust this condition, and below:

<ItemGroup Condition="'$(DotNetBuildSourceOnly)' == 'true' or '$(TargetFramework)' != 'net472'">

Test projects should use the latest, not minimum. That way your tests (which deploy MSBuild) can run against the latest.

@marcpopMSFT marcpopMSFT requested a review from ericstj May 13, 2025 23:22
@marcpopMSFT marcpopMSFT enabled auto-merge May 19, 2025 19:52
@marcpopMSFT
Copy link
Member Author

Change is breaking full framework tests:
C:\h\w\A6F708EC\p\d\sdk\10.0.100-ci\Sdks\Microsoft.NET.Sdk.StaticWebAssets\targets\Microsoft.NET.Sdk.StaticWebAssets.Pack.targets(233,5): error MSB4018: System.MissingMethodException: Method not found: '!!0 System.Text.Json.JsonSerializer.Deserialize(System.ReadOnlySpan`1, System.Text.Json.JsonSerializerOptions)'.

@marcpopMSFT
Copy link
Member Author

@ericstj I can repro locally. I've tried changing the staticwebassets task back to excludeassets but that doesn't help. I've tried switching back to an older msbuild in case there's a compat issue with VS but that didn't help. What else should I try?

@ericstj
Copy link
Member

ericstj commented May 21, 2025

I think your central update to MSBuild package version brought in a package update newer than the VS version you're running on. Probably an update to System.Memory. Same issue was hit here #48005. Are you sure the VS on your test machines has all the package versions referenced by 17.13.9? I see this references the System.Memory which just shipped 2 months ago -- so I'm skeptical.

@marcpopMSFT
Copy link
Member Author

It's supposed to be the 17.14 preview channel but I don't know the exact VS preview it installed: "windows.amd64.vs2022.pre.open" So maybe I have to wait till that updates then? I'll try updating my local VS to see if that helps since I was seeing it locally as well.

@akoeplinger
Copy link
Member

but I don't know the exact VS preview it installed:

you can see that on https://helix.dot.net/ in the Artifacts section of the queue:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants