-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix Microsoft.IO.Redist versions #48819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…fted up to a supported version Upgrade the minimum msbuild which had a 6.0.0 reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (2)
- Directory.Packages.props: Language not supported
- eng/Versions.props: Language not supported
…MSBuild is not built into the dependency graph
src/BlazorWasmSdk/Tasks/Microsoft.NET.Sdk.BlazorWebAssembly.Tasks.csproj
Outdated
Show resolved
Hide resolved
I think you should adjust this condition, and below: Line 135 in a63310c
Test projects should use the latest, not minimum. That way your tests (which deploy MSBuild) can run against the latest. |
Change is breaking full framework tests: |
@ericstj I can repro locally. I've tried changing the staticwebassets task back to excludeassets but that doesn't help. I've tried switching back to an older msbuild in case there's a compat issue with VS but that didn't help. What else should I try? |
I think your central update to MSBuild package version brought in a package update newer than the VS version you're running on. Probably an update to System.Memory. Same issue was hit here #48005. Are you sure the VS on your test machines has all the package versions referenced by 17.13.9? I see this references the System.Memory which just shipped 2 months ago -- so I'm skeptical. |
It's supposed to be the 17.14 preview channel but I don't know the exact VS preview it installed: "windows.amd64.vs2022.pre.open" So maybe I have to wait till that updates then? I'll try updating my local VS to see if that helps since I was seeing it locally as well. |
you can see that on https://helix.dot.net/ in the Artifacts section of the queue: |
Add Microsoft.IO.Redist to Directory.packages.props to ensure it's lifted up to a supported version
Upgrade the minimum msbuild which had a 6.0.0 reference