Prefer compiler toolset package if installed over the default RoslynCompilerType=Core logic
#48837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjonescz
commented
May 7, 2025
|
@jaredpar for a review, thanks |
jaredpar
reviewed
May 14, 2025
| <PropertyGroup Condition="'$(RoslynCompilerType)' == 'Core'"> | ||
| <!-- If Microsoft.Net.Compilers.Toolset package is referenced (which we can tell by RoslynTasksAssembly being non-empty), | ||
| don't overwrite target paths - the toolset package should always take precedence. --> | ||
| <PropertyGroup Condition="'$(RoslynCompilerType)' == 'Core' and '$(RoslynTasksAssembly)' == ''"> |
There was a problem hiding this comment.
In this new world though do we still want to keep preferring this package? Instead should we consider simplifying by saying that we only support Microsoft.Net.Sdk.Compilers.Toolset? Customers who previously used MS.Net.Compilers.Toolset can use the SDK version and then just control the version?
There was a problem hiding this comment.
The Sdk toolset is built from the sdk repo though, so we couldn't quickly create a toolset package (e.g., to ship hotfixes) from roslyn, we would need to insert to sdk first (with one more hop through vmr nowadays).
Also the Sdk toolset is framework only I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding compiler toolset package tests and fixing one bug here in sdk and another bug fix should flow here from roslyn (the tests verify both fixes).