Skip CanFilterAuthor_WithoutName test to unblock main #49124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR temporarily skips the CanFilterAuthor_WithoutName test to unblock the main branch by referencing issue #49123.
- Adds a
Skipattribute with a GitHub issue link to the failing test.
Comments suppressed due to low confidence (1)
test/dotnet-new.IntegrationTests/DotnetNewSearchTests.cs:222
- [nitpick] Add a TODO comment above this test method indicating when and how to re-enable the skipped test once the related issue is resolved.
[Theory]
| @@ -220,7 +220,7 @@ public void CanFilterAuthor(string testCase) | |||
| Assert.True(AtLeastOneRowIsNotEmpty(tableOutput, "Downloads"), "'Downloads' column contains empty values"); | |||
| } | |||
|
|
|||
| [Theory] | |||
| [Theory(Skip = "https://github.com/dotnet/sdk/issues/49123")] | |||
There was a problem hiding this comment.
Consider adding a brief skip reason alongside the URL, e.g., Skip = "Skipped due to issue #49123: incorrect author filtering" to clarify why the test is disabled.
Suggested change
| [Theory(Skip = "https://github.com/dotnet/sdk/issues/49123")] | |
| [Theory(Skip = "https://github.com/dotnet/sdk/issues/49123: Skipped due to issue #49123: incorrect author filtering")] |
Copilot uses AI. Check for mistakes.
nagilson
approved these changes
May 23, 2025
|
/backport to release/10.0.1xx-preview5 |
|
Started backporting to release/10.0.1xx-preview5: https://github.com/dotnet/sdk/actions/runs/15216463685 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.