Use terminal logger when building file-based apps

[jjonescz]

No description provided.

[jjonescz]

Did RunCommand.MakeTerminalLogger not create a terminal logger, you ask? No:

sdk/src/Cli/dotnet/Commands/Run/RunCommand.cs

Lines 397 to 404 in a37b351

	internal static ILogger MakeTerminalLogger(VerbosityOptions? verbosity)
	{
	var msbuildVerbosity = ToLoggerVerbosity(verbosity);
	// Temporary fix for 9.0.1xx. 9.0.2xx will use the TerminalLogger in the safe way.
	var thing = new ConsoleLogger(msbuildVerbosity);
	return thing!;
	}

But I'm not confident that should change, because that's used for evaluating the project after it's built and if terminal logger is used there, it results in additional "Build succeeded in 0.0s" message like:

whereas if the evaluation phase continues to use the console logger, it's nicely quiet.

[baronfel]

IIRC what I was planning to do was crank down the verbosity for the evaluations when I went back to TL to prevent that addtional output, but you have a point

[jaredpar]

Why not call it loggerArgs so it lines up with the property name?

Suggested change

	string[] msbuildArgs)
	string[] loggerArgs)

[jjonescz]

It's also used to fill GlobalProperties, only afterwards the property is used for logger construction, hence LoggerArgs.

[jaredpar]

Suggested change

	LoggerArgs = msbuildArgs;
	LoggerArgs = loggerArgs;