ensure that Content items are available during restore to un-break Razor #49783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a restore optimization issue where all default items were accidentally disabled, breaking Razor functionality. The fix ensures that Content items remain available during restore operations while still disabling other unnecessary default items for performance optimization.
- Changed from disabling all default items to selectively disabling only Compile, EmbeddedResource, and None items
- Added new constant for EnableDefaultContentItems to support granular control
- Updated restore optimization properties to preserve Content items needed by Razor
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Cli/dotnet/Commands/Restore/RestoringCommand.cs | Updated restore optimization to selectively disable default items instead of all items, with explanatory comment |
| src/Cli/Microsoft.DotNet.Cli.Utils/Constants.cs | Added EnableDefaultContentItems constant for granular default item control |
javiercn
approved these changes
Jul 15, 2025
ilonatommy
approved these changes
Jul 15, 2025
Open
3 tasks
baronfel
force-pushed
the
allow-content-during-restore
branch
from
c6c2c8b to
20ef9dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/dotnet/AspNetCore-ManualTests/issues/3701
We accidentally disabled all default items for review - I intended to only disable Content, Compile, EmbeddedResource, and None.
However, disabling Content items breaks Razor, who include an additional implicit PackageReference when
.razorContent items are found.