kill locking processes before doing actions that write to artifacts directories

[baronfel]

It's pretty common that I do a ./build.cmd and the redist fails to overlay the SDK because something's holding on to dlls under artifacts still. I hate finding that out at the end, so I added scripts that should terminate such processes as a pre-check when running the repo build scripts.

[Copilot]

Pull Request Overview

This PR adds process termination functionality to prevent build failures caused by lingering dotnet processes holding locks on artifacts directory files. The changes implement a Stop-ArtifactLockers function in both shell and PowerShell build scripts to identify and terminate dotnet processes that may interfere with cleaning or writing to the artifacts directory.

• Adds Stop-ArtifactLockers function to both build.sh and build.ps1 scripts
• Calls the function before cleaning artifacts directory and before main build execution
• Implements cross-platform process detection and termination logic

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
eng/common/build.sh	Adds bash implementation of Stop-ArtifactLockers function with process detection and graceful termination
eng/common/build.ps1	Adds PowerShell implementation of Stop-ArtifactLockers function with .NET process filtering

Comments suppressed due to low confidence (3)

eng/common/build.sh:265

• The function name uses PowerShell naming convention with a hyphen, but this is a bash script. Consider using bash naming convention like 'stop_artifact_lockers' or 'StopArtifactLockers'.

function Stop-ArtifactLockers {

eng/common/build.sh:385

• Function call uses PowerShell naming convention but this is bash. Should be consistent with the function definition naming.

    Stop-ArtifactLockers "$repo_root"

eng/common/build.sh:397

• Function call uses PowerShell naming convention but this is bash. Should be consistent with the function definition naming.

Stop-ArtifactLockers "$repo_root"

[Copilot]

The logic differs from the bash version - this checks if CommandLine starts with artifacts path, while bash checks if CommandLine contains artifacts DLL paths. This inconsistency could lead to different behavior between platforms.

Suggested change

	$dotnetExes = Get-Process -Name 'dotnet' -ErrorAction SilentlyContinue | Where-Object { $_.Path -eq $repoDotnetPath -and $_.CommandLine.StartsWith($artifactsRoot) }
	$dotnetExes = Get-Process -Name 'dotnet' -ErrorAction SilentlyContinue | Where-Object { $_.Path -eq $repoDotnetPath -and $_.CommandLine -match [regex]::Escape($artifactsRoot) }

[Copilot]

The regex pattern .*dotnet$ will match any process ending with 'dotnet', not necessarily the exact dotnet executable path. This could match unrelated processes with 'dotnet' in their name.

Suggested change

	done < <(pgrep -f dotnet -l 2>/dev/null | grep -E "^[0-9]+ .*dotnet$" || true)
	done < <(pgrep -f dotnet -l 2>/dev/null | grep -E "^[0-9]+ dotnet$" || true)

[joeloff]

You should make this change in Arcade. These files will be overwritten the next time an Arcade update flows through to the SDK.

[baronfel]

good call @joeloff - there's also something going on in the generated script where the .Count isn't available on the powershell array for the discovered processes. I couldn't repro on windows powershell or pwsh, though - so I don't know what's really going on there. back to the drawing board!

[MiYanni]

@baronfel You can probably just use .Length with no issues. It could also be related to the fact that PowerShell treats "one thing" and "multiple things" the same way. Enumerable containers (like arrays) are dynamic.