Skip to content

Conversation

tmat
Copy link
Member

@tmat tmat commented Sep 15, 2025

Fixes #50768

TODO:

  • Currently tests merge both stdout and stderr into a single stream of lines. Updating all tests to distinguish between app output and watch output is desirable but a lot of effort. Will leave that for later: Split application and watch output testing #50873

@tmat tmat requested a review from a team as a code owner September 15, 2025 00:04
@baronfel
Copy link
Member

We're probably going to need a breaking change notice/Tactics for this for 10 - watch is less load-bearing from a scripting perspective than the other CLI commands but it's still a major change in behavior.

@baronfel baronfel added the breaking-change Using this label will notify dotnet/compat and trigger a request to file a compat bug label Sep 15, 2025
@tmat
Copy link
Member Author

tmat commented Sep 16, 2025

@baronfel The change redirects all output from watch to stderr. However, dotnet watch invokes dotnet run to run the app and the run command does output strings to stdout, e.g. here:

https://github.com/dotnet/sdk/blob/main/src/Cli/dotnet/Commands/Run/RunCommand.cs#L222

@baronfel
Copy link
Member

Yep - I don't think we can change run entirely to change to stderr this late in the cycle though. It's one of the first things we were going to change for 11.

cc @marcpopMSFT

@marcpopMSFT
Copy link
Member

People rely on the run output being predictable. I think it's too late for run and I'd do that early in 11 and see if we got feedback.

@baronfel baronfel self-assigned this Sep 17, 2025
@jaredpar
Copy link
Member

@baronfel is anything othre than reviews blocking this?

@baronfel
Copy link
Member

@jaredpar breaking change notice emails/docs?

@jaredpar
Copy link
Member

@baronfel who is intended to do this work: @tmat, you, etc ...? Getting late into .NET 10 so want to make sure that we understand responsibilities.

@baronfel
Copy link
Member

It's on me - I've finally cleared out some other blocking work.

@baronfel
Copy link
Member

Doc issue written at dotnet/docs#48628.

@baronfel baronfel merged commit cc61994 into dotnet:release/10.0.1xx Sep 22, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Using this label will notify dotnet/compat and trigger a request to file a compat bug needs-breaking-change-doc-created
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants