Don't fall back to .NET Standard package pruning for .NET Framework #51288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronfel
approved these changes
Oct 16, 2025
ViktorHofer
approved these changes
Oct 16, 2025
ericstj
reviewed
Oct 16, 2025
| acceptNearestMatch = true; | ||
| } | ||
|
|
||
| var frameworkPackages = FrameworkPackages.GetFrameworkPackages(nugetFramework, [frameworkReference], acceptNearestMatch) |
There was a problem hiding this comment.
I wonder if we ever want nearest match behavior at all. Is there a scenario where we actually need it?
There was a problem hiding this comment.
We were also using the nearest match as part of a workaround for dotnet/windowsdesktop#4904. That may not be needed any more but I think we should keep this change as small as possible.
There was a problem hiding this comment.
Maybe we can delete in V.Next in conjunction with measuring that deleting it has zero change on all known TFMs. Just brute force and diff.
nkolev92
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #51265
Description
Prevent package pruning from occurring for .NET Framework. This was supposed to have occurred with #50816, but we missed that the prune package data logic would fall back to compatible frameworks for .NET Framework, so it ended up falling back to and using the .NET Standard pruning data.
Customer impact
This will fix various problems when compiling for .NET Framework, such as
net10.0. xunit/xunit#3413 (comment)Regression
Yes
Testing
Added automated test
Have not yet been able to validate this fixes the xUnit crash
Risk
Low