-
Notifications
You must be signed in to change notification settings - Fork 136
Create and Publish VerticalManifests during unified builds #4198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
I discussed the implementation details with @ViktorHofer. We'll be adding |
What I still want to double check with @mmitche is if the task should live in Arcade of the VMR orchestrator. When we invoke the publish action on the VMR we will call into the VMR and will need to make it not again produce a repo manifest. Alternatively if we implement this in Arcade we could add a new mode to the manifest generation that just accepts the other manifest files as an input. I'm not sure which approach is better. |
What do you mean by it producing a repo manifest again? |
@dkurepa, @mmitche and I discussed this offline. Just to add to what @dkurepa mentioned above:
@dkurepa given that we won't use Arcade's publishing infrastructure and our current build entry points, it would be easier if we just invoke the merge manifests build task in a target in build.proj that runs AfterTargets="Build" in the VMR orchestrator and write that new file directly into the artifacts folder. |
The PR for this change is in dotnet/installer#19062. We'll have to wait for dotnet/installer#18917 to get merged before merging this tho |
The pr was merged. Every VMR build leg is now producing it's own artifact that has the packages, and vertical manifests. There's a small bug with the VmrBuildNumber attribute, we opened up #4263 for it |
During unified builds, we run many legs on different OSes. Each of these legs builds multiple repos, and every repo build produces an
Asset Manifest
, that's later used in the publishing. Based on #4158, we want to use theseAsset Manifests
to create aVertical Manifest
that will contain information about all assets built in a unified build leg.We will exclude all of the information about signing, we don't need it
The text was updated successfully, but these errors were encountered: