released 2.1.300 sdk prints it is a preview message

[tmds]

When running sdk commands (e.g. dotnet build/dotnet publish) on rhel released 2.1.300 sdk, it prints out a message:

You are working with a preview version of the .NET Core SDK. You
can define the SDK version via a global.json file in the current
project. More at https://go.microsoft.com/fwlink/?linkid=869452

This is due to:

./sdk/2.1.300/Microsoft.NETCoreSdk.BundledVersions.props:    <_NETCoreSdkIsPreview>true</_NETCoreSdkIsPreview>

In our repos/cli.proj we have:

<EnvironmentVariables Include="DropSuffix=true" />

and in src/cli/build/MSBuildExtensions.targets we have:

<_NETCoreSdkIsPreview Condition=" '$(DropSuffix)' != 'true' ">true</_NETCoreSdkIsPreview>

So it's not clear for me where things go wrong.

CC @omajid @dleeapho

[omajid]

cc @crummel

[dseefeld]

@tmds Is this failing for you? Or is it just that the message says "preview" and you're able to continue?

[omajid]

It just says preview. It works fine.

$ dotnet new console
The template "Console Application" was created successfully.

Processing post-creation actions...
Running 'dotnet restore' on /home/omajid/HelloWorld/HelloWorld.csproj...
  Restoring packages for /home/omajid/HelloWorld/HelloWorld.csproj...
  Generating MSBuild file /home/omajid/HelloWorld/obj/HelloWorld.csproj.nuget.g.props.
  Generating MSBuild file /home/omajid/HelloWorld/obj/HelloWorld.csproj.nuget.g.targets.
  Restore completed in 168.89 ms for /home/omajid/HelloWorld/HelloWorld.csproj.

Restore succeeded.

$ dotnet build
Microsoft (R) Build Engine version 15.7.179.62826 for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.

  Restore completed in 34.09 ms for /home/omajid/HelloWorld/HelloWorld.csproj.
  You are working with a preview version of the .NET Core SDK. You can define the SDK version via a global.json file in the current project. More at https://go.microsoft.com/fwlink/?linkid=869452
  HelloWorld -> /home/omajid/HelloWorld/bin/Debug/netcoreapp2.1/HelloWorld.dll

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:02.11

[omajid]

It looks like the condition in the following task (in src/cli/build/MSBuildExtensions.targets) is never satisfied:

<_NETCoreSdkIsPreview Condition=" '$(DropSuffix)' != 'true' ">true</_NETCoreSdkIsPreview>

But there is also this in the same file:

<_NETCoreSdkIsPreview>$(_NETCoreSdkIsPreview)</_NETCoreSdkIsPreview>

Perhaps this is inheriting the default value, whatever that is? The bootstrap SDK defines a value for this already:

Tools/dotnetcli/sdk/2.1.300-rc1-008673/Microsoft.NETCoreSdk.BundledVersions.props:    <_NETCoreSdkIsPreview>true</_NETCoreSdkIsPreview> 

As a workaround, adding this, just below the other '$(DropSuffix)' != 'true' condition makes the message go away:

<_NETCoreSdkIsPreview Condition=" '$(DropSuffix)' == 'true' ">false</_NETCoreSdkIsPreview>

[dleeapho]

For 2.1.1 I'm ok with having a patch.

[tmds]

I'm eager to learn why this is not working as expected :)

[dseefeld]

This appears to be an issue when building a stable version of source-build with a preview version of the SDK. This needs more investigation, but moving out of 2.1.1 Servicing, since we're building 2.1.1 with stable 2.1.0 and the problem doesn't manifest in that case.