Remove obsolete arcade-services submodule and upgrade to netcoreapp3.0 version of Darc. #1368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adaggarwal
reviewed
Nov 19, 2019
adaggarwal
approved these changes
Nov 19, 2019
dseefeld
approved these changes
Nov 19, 2019
omajid
reviewed
Nov 19, 2019
crummel
added a commit
to crummel/dotnet_source-build
that referenced
this pull request
Nov 21, 2019
…0 version of Darc. (dotnet#1368) * Remove arcade-services submodule. * Upgrade Darc to netcoreapp3.0 version and remove workaround. * Remove a couple more references I missed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After dotnet/arcade-services#778, we can upgrade to a new version of Darc that supports netcoreapp3.0, which should fix issues that we've seen on ARM and newer RIDs. Also removing the obsolete submodule now that it's no longer used (fixes #1354).