Skip to content

Always pass CoreCLR msbuildonunsupportedplatform #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2017

Conversation

dagood
Copy link
Member

@dagood dagood commented Oct 30, 2017

This makes CoreCLR try to produce packages where it would normally skip doing so, e.g. Fedora 26. This allows the CoreCLR dependency to flow.

Copy link
Member

@omajid omajid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified this makes changes from coreclr flow into core-setup and even into cli. Thanks for fixing this so quickly!

@dagood
Copy link
Member Author

dagood commented Oct 30, 2017

Thanks for verifying!

I saw in CI that this arg is only supported in CoreCLR's build.sh, not build.cmd, so I added a fix for that.

@dagood dagood merged commit a69d57b into dotnet:dev/release/2.0 Oct 30, 2017
@dagood dagood deleted the always-package-coreclr branch October 30, 2017 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants