Stop building reference assembly packages #503
Conversation
|
I suspect we need something similar to this in the future for boot-strapping older packages but if we do I think we will likely do it differently so I'm find deleting all of it. Wouldn't we have the same problem with the dummy packages? Shouldn't we just rely on pre-built for those as well? |
|
Hmm, I'll leave the project files in, so we don't have to re-add if we use the same method, at least. (And maybe we'll just tweak the project if we want to do it differently.)
Good point, the same kind of error can happen with dummy packages. I'll remove them too. |
This reverts commit 6cb9e43.
| @@ -7,7 +7,6 @@ | |||
| <Import Project="..\dir.props" /> | |||
|
|
|||
| <UsingTask AssemblyFile="$(TasksBinDir)Microsoft.DotNet.SourceBuild.Tasks.dll" TaskName="GetHostInformation" /> | |||
| <UsingTask AssemblyFile="$(TasksBinDir)Microsoft.DotNet.SourceBuild.Tasks.dll" TaskName="BuildDummyPackages" /> | |||
There was a problem hiding this comment.
Do we want to remove this task as well?
There was a problem hiding this comment.
I think this is similar to whether or not we should remove the reference assembly project: I don't think we should, in case this becomes a valid way to work around a problem again in the future.
|
Offline tarball build output succeeds |
This will remove the possibility for a type of build error we've seen quite a few times, and is hard to debug: we have a prebuilt version of a package in the tarball, but the reference assembly package replaces it and doesn't contain the assets required to make a functional product.
Removing the reference assembly focuses our effort to removing prebuilts by using source-built packages, rather than maintaining these compile-only packages.
(I haven't run this locally yet.)