-
Notifications
You must be signed in to change notification settings - Fork 136
Add additional ProdCon updaters pointed at recent 2.1.1 build #602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update OfficialBuildId from BuildId in the manifest. Update ProdCon feed to latest in manifest. Auto-update buildtools from master.
repos/dir.targets
Outdated
@@ -371,6 +371,7 @@ | |||
|
|||
<Target Name="GetProjectDirectory" Outputs="$(ProjectDirectory)" /> | |||
<Target Name="GetOrchestratedManifestBuildName" Outputs="$(OrchestratedManifestBuildName)" /> | |||
<Target Name="GetOfficialBuildId" Outputs="OfficialBuildId" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be $(OfficialBuildId)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, yep. As-is this ends up creating a build id updater for every project unconditionally.
2.1.1 CoreFX can't build with the master (2.2.0) BuildTools version.
In this PR I updated buildtools to Once dotnet/buildtools#2063 is through, we'll have a 2.1 BuildTools that includes the updaters. We're also at an awkward place where #589 will update the Core repos to |
@crummel, looks like I also ran into the reason we need net46 builds. (#592)
I'll revert the upgrade entirely for now, and just get the configuration in. Edit: The port of the new updaters to BuildTools 2.1 is done. I updated to that version so the auto-update configuration won't immediately fail because of the updater types not existing. |
This reverts commit c6cd027.
This brings in the new updaters without any other changes.
Upgrades buildtools to get new updaters implemented in dotnet/buildtools#2047 and configures them, pointing at the recent 2.1.1 build.
I'm planning on porting the buildtools change from master to 2.1 once this gets merged, then porting this PR to source-build 2.1.
Ideally I'd use a master manifest rather than 2.1.1, but we don't have one. The source-build
master
appears to still be on 2.1.0 for now so this is still an upgrade.#534