Skip to content

Add WPF's C++ sources to source-index #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vatsan-madhavan opened this issue Sep 27, 2019 · 3 comments
Closed

Add WPF's C++ sources to source-index #42

vatsan-madhavan opened this issue Sep 27, 2019 · 3 comments

Comments

@vatsan-madhavan
Copy link
Member

<Repository Include="wpf">
<Url>https://github.com/dotnet/wpf</Url>
<Projects>
src/Microsoft.DotNet.Wpf/src/*/*.csproj
</Projects>
<PrepareCommand>
$(VsDevCmd) &amp; build
</PrepareCommand>

Currently, only *.csproj are indexed from https://github.com/dotnet/wpf. WPF consists of .vcxproj (C++, C++/CLI) projects as well - can we include them in indexing as well?

/cc @dotnet/wpf-developers

@alexperovich
Copy link
Member

The source indexer doesn't support C++. It doesn't have any way of indexing source code that isn't processable by Roslyn.

@KirillOsenkov
Copy link
Member

Yes I'm afraid this is non-actionable without a very significant time investment (is there even a "Roslyn" for C++?).

@weltkante
Copy link

weltkante commented Sep 28, 2019

It may be possible to look at the managed part of the mixed mode assembly via Roslyn and together with the pdb reassociate the symbols with line numbers in the source? I didn't check which Roslyn API the indexer uses, so I can't judge how much work that would be. Also not as extensive as the full method body indexing but it would be a start which allows to at least navigate the mixed mode managed definitions.

[edit] thinking about it I realize thats only half of what indexing does, you don't get references from C++/CLI to anything else indexed this way, that would require inspecting the IL I guess, which is probably too much work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants