-
Notifications
You must be signed in to change notification settings - Fork 329
Modify RowConstructor to work with WithColumn #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imback82
reviewed
Aug 20, 2019
Can you check the test failures? |
imback82
reviewed
Aug 24, 2019
2a5d462
to
4cb15f1
Compare
imback82
reviewed
Sep 5, 2019
imback82
reviewed
Sep 7, 2019
src/csharp/Microsoft.Spark.E2ETest/IpcTests/Sql/DataFrameTests.cs
Outdated
Show resolved
Hide resolved
imback82
reviewed
Sep 9, 2019
imback82
previously approved these changes
Sep 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great work!
imback82
approved these changes
Sep 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows nested Rows with nested StructTypes to be properly unpickled as well as allows Rows to be passed to Udfs by using the WithColumn method.
Produces the following Schema for the
ageIsNullDF
DataframeBenchmark:
HDInsight
D14v2 16 CPU, 112GB Ram
Spark 2.3.2
tpch query 1
dataset size 2.8GB Parquet (generated with db-gen with a 9 scale factor)
master
->72fdf4834d5d9e7df06efec29233734aaec9445b
PR
->882cdbe9ac8f657163a6777a72577db45f1b0154
local[14]
master
PR
92527.89
86570.89
local[7]
master
PR
41274.10
40804.10