Support for Bucketizer #378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 tasks
|
@suhsteve can you help reviewing this? |
suhsteve
reviewed
Jan 8, 2020
src/csharp/Microsoft.Spark.E2ETest/IpcTests/ML/Feature/BucketizerTests.cs
Show resolved
Hide resolved
Co-Authored-By: Steve Suh <[email protected]>
Co-Authored-By: Steve Suh <[email protected]>
Co-Authored-By: Steve Suh <[email protected]>
Co-Authored-By: Steve Suh <[email protected]>
|
I have updated after the comments, let me know whether the |
suhsteve
reviewed
Jan 10, 2020
added 6 commits
January 13, 2020 07:42
added 2 commits
January 13, 2020 22:09
|
@suhsteve I have re-written this now so that SerDe can understand a double[][] - I used a 'A' as the identifier, if there are any rules about which letter to use let me know and i'll change it. |
suhsteve
reviewed
Jan 14, 2020
src/csharp/Microsoft.Spark.E2ETest/IpcTests/ML/Feature/BucketizerTests.cs
Outdated
Show resolved
Hide resolved
src/csharp/Microsoft.Spark.E2ETest/IpcTests/ML/Feature/BucketizerTests.cs
Outdated
Show resolved
Hide resolved
src/csharp/Microsoft.Spark.E2ETest/IpcTests/ML/Feature/BucketizerTests.cs
Outdated
Show resolved
Hide resolved
|
I've made the changes after the code review, let me know any other changes |
Co-Authored-By: Steve Suh <[email protected]>
|
Great thanks :) |
imback82
reviewed
Jan 17, 2020
src/csharp/Microsoft.Spark.E2ETest/IpcTests/ML/Feature/BucketizerTests.cs
Outdated
Show resolved
Hide resolved
src/csharp/Microsoft.Spark.E2ETest/IpcTests/ML/Feature/BucketizerTests.cs
Outdated
Show resolved
Hide resolved
src/csharp/Microsoft.Spark.E2ETest/IpcTests/ML/Feature/BucketizerTests.cs
Outdated
Show resolved
Hide resolved
src/scala/microsoft-spark-2.3.x/src/main/scala/org/apache/spark/api/dotnet/SerDe.scala
Outdated
Show resolved
Hide resolved
src/scala/microsoft-spark-2.4.x/src/main/scala/org/apache/spark/api/dotnet/SerDe.scala
Outdated
Show resolved
Hide resolved
src/scala/microsoft-spark-2.3.x/src/main/scala/org/apache/spark/api/dotnet/SerDe.scala
Show resolved
Hide resolved
src/scala/microsoft-spark-3.0.x/src/main/scala/org/apache/spark/api/dotnet/SerDe.scala
Outdated
Show resolved
Hide resolved
added 3 commits
January 17, 2020 08:39
imback82
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements Bucketizer (https://spark.apache.org/docs/latest/ml-features#bucketizer) and completes #313
This implements the concrete methods on Bucketizer that are needed to run the transform.