Get the GetService into HttpContextWrapper #457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twsouthwick
reviewed
Dec 8, 2023
|
|
||
| public override object GetService(Type serviceType) | ||
| { | ||
| return ((HttpContextCore)_context).RequestServices.GetService(serviceType); |
There was a problem hiding this comment.
this should delegate to the _context.GetService method. The HttpContext.GetService() method could hook into the _context.RequestServices
birojnayak
force-pushed
the
HttpContextWrapperFix
branch
from
de5ee2d to
6f5b309
Compare
birojnayak
commented
Dec 8, 2023
twsouthwick
requested changes
Dec 8, 2023
| @@ -81,5 +81,10 @@ public override IPrincipal User | |||
| public override void RewritePath(string filePath, string pathInfo, string? queryString, bool setClientFilePath) => _context.RewritePath(filePath, pathInfo, queryString, setClientFilePath); | |||
|
|
|||
| public override void SetSessionStateBehavior(SessionStateBehavior sessionStateBehavior) => _context.SetSessionStateBehavior(sessionStateBehavior); | |||
|
|
|||
| public override object? GetService(Type serviceType) | |||
| { | |||
There was a problem hiding this comment.
nit: use expression instead similar to the rest of the methods
birojnayak
force-pushed
the
HttpContextWrapperFix
branch
from
6f5b309 to
1de5364
Compare
birojnayak
force-pushed
the
HttpContextWrapperFix
branch
from
1de5364 to
f5eda9b
Compare
twsouthwick
reviewed
Dec 14, 2023
birojnayak
added a commit
to birojnayak/systemweb-adapters
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting GetService to HttpContextWrapper . This will fix the issue #456