Skip to content

Ensure SessionAttribute defaults to same behavior as 1.2 #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

twsouthwick
Copy link
Member

@twsouthwick twsouthwick commented Jan 9, 2024

As part of expanding the session support to enable per request changing the session behavior in #399, it appears that the default SessionAttribute was changed to have a different default value.

Fixes #455

@twsouthwick
Copy link
Member Author

@joperezr not sure who I should be adding for reviews now, but once this is merged, we should push a v1.3.1 to fix this and a couple other regressions that have been fixed

@twsouthwick twsouthwick enabled auto-merge (squash) January 9, 2024 02:32
@joperezr
Copy link
Member

joperezr commented Jan 9, 2024

We haven't really defined who will be the dev working on this repo yet, but I'm happy to take a look at this one. Seems like it was a regression (reported by the community) and fix seems trivial and tested, so I'm supportive of this. Happy to ship a new version with this, but do note that main is currently 1.4.0 as opposed to 1.3.1. Do we care about it being 1.3.1?

@twsouthwick twsouthwick merged commit f71eb39 into main Jan 9, 2024
@twsouthwick twsouthwick deleted the session-default branch January 9, 2024 18:12
@twsouthwick
Copy link
Member Author

Following semantic versioning would put us at 1.3.1, but 1.4.0 is fine if it will cause problems to change the version

@joperezr
Copy link
Member

joperezr commented Jan 9, 2024

It shouldn't it is just a matter of one more update in Versions.props. Or alternatively creating a release/3.1 branch from the commit that released 1.3.0 and cherry-picking this PR there. Either option would be fine.

@twsouthwick
Copy link
Member Author

It would be great to just take all 4 commits since 1.3 and release it as 1.3.1 - however that needs to be done I'll leave up to you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants