Skip to content

Exit codes review #4776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Exit codes review #4776

wants to merge 3 commits into from

Conversation

JanKrivanek
Copy link
Member

@JanKrivanek JanKrivanek commented May 23, 2022

Problem

Review and adjust exit codes from New3CommandResult #3186

Options:

  • We probably want to move away from HResults - but just for sure, added as well proposals for what the proper HResults could be.
  • Added as well proposals for unix style exit codes (0-255)
  • Alternatively we can exit with 0 (success) / 1 (error) - as it seems to be done by quite a few of our CLI tools (e.g. MSBuild exit code)

@baronfel - your insight and thoughts would be very appreciated here

Solution

Proposed what HResult or Unix compatible exit codes can be used for particular states - no actual code change yet Mostly collecting feedback now

Checks:

  • Added unit tests
  • Added #nullable enable to all the modified files ?

@JanKrivanek
Copy link
Member Author

Superseded by #4787

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant