Repository navigation
Bump coverlet version - #78
Conversation
|
@nohwnd Once this goes in, we can probably go ahead and make insertion for the templates as well |
AbhitejJohn
left a comment
There was a problem hiding this comment.
@MarcoRossignoli : Thanks. What validation do we usually run on these updates?
Probably not tied to this template change anyway but do we have tests validating this works with other recent major versions of the Test SDK package apart from the current one.
|
Recently added some integration tests https://github.com/tonerdo/coverlet/blob/master/test/coverlet.integration.tests/Collectors.cs Feel free to clone and check if it's enough or if you've other ideas https://github.com/tonerdo/coverlet/tree/master/test/coverlet.integration.tests Could be useful if when you release new package PR also an update on integration(your smoke) tests on coverlet or notify me(email?), maybe I can check if it's possible setup dependabot on that project for release/pre-release |
|
@MarcoRossignoli : That's good indeed. Noticed though that we use the latest version of the Test SDK. We'd probably want to have a test that validates with the version that ships in this template. We could definitely keep you in loop when we ship a new version (@nohwnd , it would be great if you could add this to the release steps.) or update the template here. It would be nice to have this automated for sure. I haven't really used dependabot - how does it integrate with code/build pipeline updates. |
Ok if we want to test that it works with template sdk I can update test to test for every sdk shipped in template, I'll work on it. In this case cannot use dependabot but it's not a problem. |
|
Ok we've multi sdk tests coverlet-coverage/coverlet#687 |
|
Can we merge this guy @nohwnd? |
|
any news? |
|
@MarcoRossignoli I actually did not have permissions to merge anything here. Is the 1.1.1 still good to go? No influx of bugs for that version? |
|
We fixed a lot of edge case and bugs in last two release https://github.com/tonerdo/coverlet/blob/master/Documentation/Changelog.md from 1.1.0 onwards, I mean users can use this version and upgrade lib if needed(if they notice new one). It's not mandatory, but from time to time we should bump a bit, or we should understand how to handle this workflow. |
Sorry, I was just reacting to this comment (and got the version wrong). Let me re-iterate. :) Do you still feel that 1.2.0 is good stable release as you did when creating this PR? Say yes and I will merge 🙂 |
|
BTW more importand is test sdk because when inproc collectors fails to load no warning/error show to user and they could hit "100ms kill" I've just updated guide https://github.com/tonerdo/coverlet/blob/master/Documentation/VSTestIntegration.md
Hehe 😃 you know how our work is...I would say yes 1 month out and no issue on it, I fixed some CI on users repo with this new version and no complain so I feel ok, btw in case of issue we'll ask to user to downgrade ver, do you have some internal "rule" to decide when release stable version?I know that depends on project but I'd like to know. |
|
So yes! |
|
Thanks @nohwnd! |

closes #77
Upgrade to last version released a week ago https://www.nuget.org/packages/coverlet.collector/ 10K download and no issue on repo for now
If it's too brave we can update with
1.1.0433K download, however we can always tell to user to downgrade in case.Fixed searching for
findstr /n /s /c:"coverlet.collector" *proj/cc: @singhsarab @nohwnd @shyamnamboodiripad @AbhitejJohn