Move omnisharp vscode to the new hover implementation

[333fred]

Hover implemention is in PR here: OmniSharp/omnisharp-roslyn#1860.

Fixes #3652

[333fred]

Some examples of what this looks like:

[333fred]

This is not going to pass until we bump the omnisharp server version with the new API.

[filipw]

nice!

[JoeRobich]

Updating OmniSharp to include the server-side changes in #3960

[codecov]

Codecov Report

Merging #3928 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3928   +/-   ##
=======================================
  Coverage   85.92%   85.93%           
=======================================
  Files          60       60           
  Lines        1847     1848    +1     
  Branches      215      215           
=======================================
+ Hits         1587     1588    +1     
  Misses        200      200           
  Partials       60       60           

Flag	Coverage Δ
#integration	100.00% <ø> (ø)
#unit	85.93% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/omnisharp/protocol.ts	78.19% <100.00%> (+0.16%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e059df...220af7f. Read the comment docs.

[JoeRobich]

@333fred GH checks haven't been updating. I saw this test failure in the build log - https://travis-ci.org/github/OmniSharp/omnisharp-vscode/builds/716733894

  1 failing
  1) Hover Provider: single csproj at root of workspace
       Hover returns structured documentation with proper newlines:
      AssertionError: expected '```csharp\nbool testissue.Compare(int gameObject, string tagName)\n```\n\nChecks if object is tagged with the tag\\.\n\nReturns:\n\n  Returns true if object is tagged with tag\\.' to equal '```csharp\nbool testissue.Compare(int gameObject, string tagName)\n```\n\nChecks if object is tagged with the tag.\n\nReturns:\n\n  Returns true if object is tagged with tag.'
      + expected - actual
       ```csharp
       bool testissue.Compare(int gameObject, string tagName)
       ```
       
      -Checks if object is tagged with the tag\.
      +Checks if object is tagged with the tag.
       
       Returns:
       
      -  Returns true if object is tagged with tag\.
      +  Returns true if object is tagged with tag.
      
      at Context.<anonymous> (test/integrationTests/hoverProvider.integration.test.ts:47:82)
      at Generator.next (<anonymous>)
      at fulfilled (out/test/integrationTests/hoverProvider.integration.test.js:9:58)
      at processTicksAndRejections (internal/process/task_queues.js:85:5)

[333fred]

@JoeRobich should be fixed. The baseline needed to be updated for the additional escaping done on the server.

[JoeRobich]

Passing CI - https://travis-ci.org/github/OmniSharp/omnisharp-vscode/builds/716794826

[JoeRobich]

Thanks @333fred!

[vchirikov]

Hi, thanks for feature, can we have the same highlighting in parameter-hints-widget or it is a vs-code issue?

microsoft/vscode#105286

[filipw]

This is a VS Code issue - microsoft/vscode#55044