Skip to content

Update typescript and eslint plugin to remove build warning#6002

Merged
dibarbet merged 1 commit intodotnet:mainfrom
dibarbet:update_ts
Aug 3, 2023
Merged

Update typescript and eslint plugin to remove build warning#6002
dibarbet merged 1 commit intodotnet:mainfrom
dibarbet:update_ts

Conversation

@dibarbet
Copy link
Copy Markdown
Member

@dibarbet dibarbet commented Aug 3, 2023

Underlying issue preventing an upgrade before has been resolved - typescript-eslint/typescript-eslint#6934

Before:

PS C:\Users\dabarbet\source\repos\vscode-csharp> npm run compile

> csharp@2.0.0-placeholder compile
> tsc -p ./ && npx eslint ./

=============

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <5.1.0

YOUR TYPESCRIPT VERSION: 5.1.3

Please only submit bug reports when using the officially supported version.

=============

With this change:

PS C:\Users\dabarbet\source\repos\vscode-csharp> npm run compile

> csharp@2.0.0-placeholder compile
> tsc -p ./ && npx eslint ./

PS C:\Users\dabarbet\source\repos\vscode-csharp>

@dibarbet dibarbet requested a review from a team as a code owner August 3, 2023 01:21
@dibarbet dibarbet enabled auto-merge August 3, 2023 01:35
@dibarbet dibarbet merged commit 5ee4e55 into dotnet:main Aug 3, 2023
@dibarbet dibarbet deleted the update_ts branch August 3, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants