Skip to content

Disable server restart command with devkit #7731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

dibarbet
Copy link
Member

@dibarbet dibarbet commented Nov 1, 2024

This gets people into trouble since restarting the server means project information is lost when using devkit. See #5882

So disable this command when devkit is enabled

@dibarbet dibarbet requested a review from a team as a code owner November 1, 2024 23:20
@dibarbet dibarbet requested a review from arunchndr November 1, 2024 23:21
@@ -1898,7 +1898,7 @@
"command": "dotnet.restartServer",
"title": "%command.dotnet.restartServer%",
"category": ".NET",
"enablement": "dotnet.server.activationContext != 'OmniSharp'"
"enablement": "dotnet.server.activationContext == 'Roslyn'"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Roslyn' means standalone C#

@dibarbet dibarbet merged commit 1c7c84e into dotnet:main Nov 2, 2024
14 of 16 checks passed
@dibarbet dibarbet deleted the disable_restart_devkit branch November 2, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants