Skip to content

Fix missing timeout when reading response stream #3767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2019
Merged

Fix missing timeout when reading response stream #3767

merged 1 commit into from
Jul 29, 2019

Conversation

mconnew
Copy link
Member

@mconnew mconnew commented Jul 24, 2019

Fixes #3724

@StephenBonikowsky
Copy link
Member

Closing and re-opening to trigger all the checks again.

@StephenBonikowsky
Copy link
Member

Ignore the two cancelled runs, they are being re-run but the two cancelled runs don't get removed from the list of checks.

@StephenBonikowsky
Copy link
Member

Had to fix the PR service, the certificate setup script failed when run earlier today.

@StephenBonikowsky
Copy link
Member

Something is all screwed up with the build system.
Going to close once more and re-open.

@StephenBonikowsky
Copy link
Member

Sorry for the mess @mconnew
There was another issue with the script on the PR server.
The current run should all pass, assuming the checks are kicked off correctly, it doesn't seem to like having multiple runs kicked-off after failures.

@StephenBonikowsky StephenBonikowsky merged commit 5e517d4 into dotnet:master Jul 29, 2019
@mconnew mconnew deleted the Issue3724 branch September 27, 2019 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timeouts are not fully respected by the WCF client
2 participants
@mconnew @StephenBonikowsky