Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Oct 23, 2025

Backport of #13949 to release/10.0

/cc @JeremyKuhne

Customer Impact

Corrupted clipboard data can cause application crashes when attempting to retrieve the data. There is no workaround in some cases as crashes can cause an access violation.

Testing

Unit tests added to cover bad HGLOBAL state.

Risk

Low, adding guards for corrupted state.

Microsoft Reviewers: Open in CodeFlow

Manually look for the terminator and return empty string if there is no terminator. Throw for bad HGLOBALs.

Needed to add some more code for testing nested private generic classes.
@github-actions github-actions bot requested a review from a team as a code owner October 23, 2025 18:44
@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 73.21429% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.10003%. Comparing base (93e65c0) to head (c7feeb3).
⚠️ Report is 1 commits behind head on release/10.0.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           release/10.0      #13988         +/-   ##
======================================================
- Coverage      77.10159%   77.10003%   -0.00156%     
======================================================
  Files              3273        3273                 
  Lines            644940      644979         +39     
  Branches          47692       47701          +9     
======================================================
+ Hits             497259      497279         +20     
- Misses           144013      144025         +12     
- Partials           3668        3675          +7     
Flag Coverage Δ
Debug 77.10003% <73.21429%> (-0.00156%) ⬇️
integration 18.98432% <3.22581%> (-0.00786%) ⬇️
production 51.91538% <77.41935%> (+0.00122%) ⬆️
test 97.40958% <68.00000%> (-0.00298%) ⬇️
unit 49.33561% <77.41935%> (+0.00527%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JeremyKuhne JeremyKuhne added 🚫 * NO-MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) servicing-consider .NET Shiproom label indicating a PR seeks to enter into a branch under Tell-Mode criteria labels Oct 23, 2025
@JeremyKuhne JeremyKuhne added this to the .NET 10.0 milestone Oct 23, 2025
@JeremyKuhne JeremyKuhne added servicing-approved .NET Shiproom approved the PR for merge and removed servicing-consider .NET Shiproom label indicating a PR seeks to enter into a branch under Tell-Mode criteria 🚫 * NO-MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) labels Oct 23, 2025
@JeremyKuhne JeremyKuhne merged commit 10bf112 into release/10.0 Oct 23, 2025
8 checks passed
@JeremyKuhne JeremyKuhne deleted the backport/pr-13949-to-release/10.0 branch October 23, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

servicing-approved .NET Shiproom approved the PR for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants