Cleanup System.Security.Permissions using directives and more comments (#1272)

* permissions cleanup

* comment removals

Author: ojhad

eng/WpfArcadeSdk/tools/TestProjects.targets

@@ -30,7 +30,6 @@
     <PackageReference Include="System.Configuration.ConfigurationManager" Version="$(SystemConfigurationConfigurationManagerPackageVersion)" CopyLocal="true"  />
     <PackageReference Include="System.Diagnostics.EventLog" Version="$(SystemDiagnosticsEventLogPackageVersion)" CopyLocal="true" />
     <PackageReference Include="System.Security.Cryptography.Xml" Version="$(SystemSecurityCryptographyXmlPackageVersion)" CopyLocal="true" />
-    <PackageReference Include="System.Security.Permissions" Version="$(SystemSecurityPermissionsPackageVersion)" CopyLocal="true" />
     <PackageReference Include="System.Windows.Extensions" Version="$(SystemWindowsExtensionsPackageVersion)" CopyLocal="true" />
 
     <PackageReference Include="System.Security.AccessControl" Version="$(SystemSecurityAccessControlPackageVersion)" CopyLocal="true" />

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Automation/Peers/AutomationPeer.cs

@@ -219,8 +219,6 @@ public sealed class HostedWindowWrapper
     {
         /// <summary>
         /// This is the only public constructor on this class.
-        /// It requires "Full Trust" level of security permissions to be executed, since this
-        /// class is wrappign an HWND direct access to which is a critical asset.
         /// </summary>
         public HostedWindowWrapper(IntPtr hwnd)
         {

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Generated/ContentElement.cs

@@ -18,7 +18,6 @@
 using System.ComponentModel;
 using System.Diagnostics;
 using System.Security;
-using System.Security.Permissions;
 using System.Windows.Input;
 using System.Windows.Media.Animation;
 

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Generated/UIElement.cs

@@ -18,7 +18,6 @@
 using System.ComponentModel;
 using System.Diagnostics;
 using System.Security;
-using System.Security.Permissions;
 using System.Windows.Input;
 using System.Windows.Media.Animation;
 

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Generated/UIElement3D.cs

@@ -18,7 +18,6 @@
 using System.ComponentModel;
 using System.Diagnostics;
 using System.Security;
-using System.Security.Permissions;
 using System.Windows.Input;
 using System.Windows.Media.Animation;
 

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Input/Command/ApplicationCommands.cs

@@ -20,7 +20,6 @@
 using System.Collections;
 using System.ComponentModel;
 using System.Security;
-using System.Security.Permissions;
 using SR=MS.Internal.PresentationCore.SR;
 using SRID=MS.Internal.PresentationCore.SRID;
 using MS.Internal; // CommandHelper

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Input/Command/RoutedCommand.cs

@@ -284,9 +284,6 @@ private InputGestureCollection GetInputGestures()
         ///     Will be set by Rights Management code.
         /// </summary>
         /// <value></value>
-        /// <remarks>
-        ///     Callers must have UIPermission(PermissionState.Unrestricted) to call this API.
-        /// </remarks>
         internal bool IsBlockedByRM
         {
             get

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Input/InputManager.cs

@@ -40,9 +40,6 @@ public sealed class InputManager : DispatcherObject
         /// <summary>
         ///     Return the input manager associated with the current context.
         /// </summary>
-        /// <remarks>
-        ///     Callers must have UIPermission(PermissionState.Unrestricted) to call this API.
-        /// </remarks>
         public static InputManager Current
         {
             get
@@ -180,10 +177,6 @@ private InputManager()
             _inputTimer.Interval = TimeSpan.FromMilliseconds(125);
         }
 
-        /// <summary></summary>
-        /// <remarks>
-        ///     Callers must have UIPermission(PermissionState.Unrestricted) to call this API.
-        /// </remarks>
         public event PreProcessInputEventHandler PreProcessInput
         {
             add
@@ -196,11 +189,6 @@ public event PreProcessInputEventHandler PreProcessInput
             }
         }
 
-
-        /// <summary></summary>
-        /// <remarks>
-        ///     Callers must have UIPermission(PermissionState.Unrestricted) to call this API.
-        /// </remarks>
         public event NotifyInputEventHandler PreNotifyInput
         {
             add
@@ -212,10 +200,6 @@ public event NotifyInputEventHandler PreNotifyInput
                 _preNotifyInput -= value;
             }
 }
-        /// <summary></summary>
-        /// <remarks>
-        ///     Callers must have UIPermission(PermissionState.Unrestricted) to call this API.
-        /// </remarks>
         public event NotifyInputEventHandler PostNotifyInput
         {
             add
@@ -228,10 +212,6 @@ public event NotifyInputEventHandler PostNotifyInput
 }
         }
 
-        /// <summary></summary>
-        /// <remarks>
-        ///     Callers must have UIPermission(PermissionState.Unrestricted) to call this API.
-        /// </remarks>
         public event ProcessInputEventHandler PostProcessInput
         {
             add
@@ -300,9 +280,6 @@ internal void UnregisterInputProvider(IInputProvider inputProvider)
         /// <summary>
         ///     Returns a collection of input providers registered with the input manager.
         /// </summary>
-        /// <remarks>
-        ///     Callers must have UIPermission(PermissionState.Unrestricted) to call this API.
-        /// </remarks>
         public ICollection InputProviders
         {
             get
@@ -568,7 +545,6 @@ private void ValidateInputDevices(object sender, EventArgs e)
         ///     The specified input is processed by all of the filters and
         ///     monitors, and is finally dispatched to the appropriate
         ///     element as an input event.
-        ///     Callers must have UIPermission(PermissionState.Unrestricted) to call this API.
         /// </remarks>
         /// <returns>
         ///     Whether or not any event generated as a consequence of this

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Input/InputMethod.cs

@@ -642,10 +642,7 @@ public InputMethodState ImeState
 
         /// <summary> 
         /// Access the current microphone on/off status.
-        /// </summary> 
-        /// <remarks>
-        ///     Callers must have UIPermission(PermissionState.Unrestricted) to call this API.
-        /// </remarks>
+        /// </summary>
         public InputMethodState MicrophoneState
         {
             get
@@ -716,9 +713,6 @@ public InputMethodState HandwritingState
         /// <summary> 
         /// Access the current speech mode
         /// </summary> 
-        /// <remarks>
-        ///     Callers must have UIPermission(PermissionState.Unrestricted) to call this API.
-        /// </remarks>
         public SpeechMode SpeechMode
         {
             get

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Input/KeyEventArgs.cs

@@ -51,9 +51,6 @@ public KeyEventArgs(KeyboardDevice keyboard, PresentationSource inputSource, int
         /// <summary>
         ///     The input source that provided this input.
         /// </summary>
-        /// <remarks>
-        ///     Callers must have UIPermission(PermissionState.Unrestricted) to call this API.
-        /// </remarks>
         public PresentationSource InputSource
         {
             get 

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Input/KeyboardDevice.cs

@@ -88,10 +88,6 @@ internal IInputElement ForceTarget
         /// <summary>
         ///     Returns the PresentationSource that is reporting input for this device.
         /// </summary>
-        /// <remarks>
-        ///     Callers must have UIPermission(PermissionState.Unrestricted) to call this API.
-        /// </remarks>
-
         public override PresentationSource ActiveSource
         {
             get

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Input/NotifyInputEventArgs.cs

@@ -40,9 +40,6 @@ internal virtual void Reset(StagingAreaInputItem input, InputManager inputManage
         /// <summary>
         ///     The input manager processing the input event.
         /// </summary>
-        /// <remarks>
-        ///     Callers must have UIPermission(PermissionState.Unrestricted) to call this API.
-        /// </remarks>
         public InputManager InputManager 
         {
             get 

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Input/ProcessInputEventArgs.cs

@@ -50,9 +50,6 @@ internal override void Reset(StagingAreaInputItem input, InputManager inputManag
         /// <returns>
         ///     The staging area input item that wraps the specified input.
         /// </returns>
-        ///<remarks>
-        ///     Callers must have UIPermission(PermissionState.Unrestricted) to call this API.
-        ///</remarks> 
         public StagingAreaInputItem PushInput(InputEventArgs input, 
                                               StagingAreaInputItem promote) // Note: this should be a bool, and always use the InputItem available on these args.
         {
@@ -73,10 +70,7 @@ public StagingAreaInputItem PushInput(InputEventArgs input,
         /// </param>
         /// <returns>
         ///     The specified staging area input item.
-        /// </returns>
-        ///<remarks>
-        ///     Callers must have UIPermission(PermissionState.Unrestricted) to call this API.
-        ///</remarks>        
+        /// </returns>      
         public StagingAreaInputItem PushInput(StagingAreaInputItem input)
         {
             if(!_allowAccessToStagingArea)
@@ -93,10 +87,7 @@ public StagingAreaInputItem PushInput(StagingAreaInputItem input)
         /// <returns>
         ///     The input event that was on the top of the staging area.
         ///     This can be null, if the staging area was empty.
-        /// </returns>
-        /// <remarks>
-        ///     Callers must have UIPermission(PermissionState.Unrestricted) to call this API.
-        /// </remarks>        
+        /// </returns>    
         public StagingAreaInputItem PopInput()
         {
 
@@ -115,9 +106,6 @@ public StagingAreaInputItem PopInput()
         ///     The input event that is on the top of the staging area.
         ///     This can be null, if the staging area is empty.
         /// </returns>
-        /// <remarks>
-        ///     Callers must have UIPermission(PermissionState.Unrestricted) to call this API.
-        /// </remarks>
         public StagingAreaInputItem PeekInput()
         {
 

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Input/StagingAreaInputItem.cs

@@ -50,9 +50,6 @@ internal void Reset(InputEventArgs input, StagingAreaInputItem promote)
         /// <summary>
         ///     Returns the input event.
         /// </summary>
-        /// <remarks>
-        ///     Callers must have UIPermission(PermissionState.Unrestricted) to call this API.
-        /// </remarks>
         public InputEventArgs Input
         {
             get {return _input;}
@@ -83,9 +80,6 @@ public object GetData(object key)
         /// <param name="value">
         ///     The data to set for this key.  This can be null.
         /// </param>
-        /// <remarks>
-        ///     Callers must have UIPermission(PermissionState.Unrestricted) to call this API.
-        /// </remarks>
         public void SetData(object key, object value)
         {
             _dictionary[key] = value;

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Input/TextComposition.cs

@@ -142,9 +142,6 @@ internal TextComposition(InputManager inputManager, IInputElement source, string
         /// <summary>
         ///     Finalize the composition.
         /// </summary>
-        /// <remarks>
-        ///     Callers must have UIPermission(PermissionState.Unrestricted) to call this API.
-        /// </remarks>
         public virtual void Complete()
         {
 //             VerifyAccess();

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Input/TextCompositionManager.cs

@@ -285,9 +285,6 @@ internal TextCompositionManager(InputManager inputManager)
         /// <summary>
         ///     Start the composition.
         /// </summary>
-        /// <remarks>
-        ///     Callers must have UIPermission(PermissionState.Unrestricted) to call this API.
-        /// </remarks>
         public static bool StartComposition(TextComposition composition)
         {
             return UnsafeStartComposition(composition);
@@ -296,9 +293,6 @@ public static bool StartComposition(TextComposition composition)
         /// <summary>
         ///     Update the composition.
         /// </summary>
-        /// <remarks>
-        ///     Callers must have UIPermission(PermissionState.Unrestricted) to call this API.
-        /// </remarks>
         public static bool UpdateComposition(TextComposition composition)
         {
             return UnsafeUpdateComposition(composition);
@@ -307,9 +301,6 @@ public static bool UpdateComposition(TextComposition composition)
         /// <summary>
         ///     Complete the composition.
         /// </summary>
-        /// <remarks>
-        ///     Callers must have UIPermission(PermissionState.Unrestricted) to call this API.
-        /// </remarks>
         public static bool CompleteComposition(TextComposition composition)
         {
             return UnsafeCompleteComposition(composition);

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/InterOp/HwndTarget.cs

@@ -2631,9 +2631,6 @@ public bool DetachHwndTarget(HwndTarget hwndTarget)
             /// <summary>
             ///     Handles the messages for the notification window
             /// </summary>
-            /// <SecurityNode>
-            ///     Critical: Elevates permissions via unsafe native methods
-            /// </SecurityNode>
             private IntPtr NotificationFilterMessage(IntPtr hwnd, int msg, IntPtr wParam, IntPtr lParam, ref bool handled)
             {
                 IntPtr retInt = IntPtr.Zero;

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Media/Animation/Generated/Animatable.cs

@@ -22,7 +22,6 @@
 using System.Collections.Generic;
 using System.Diagnostics;
 using System.Security;
-using System.Security.Permissions;
 using System.Windows.Threading;
 using System.Windows.Media.Animation;
 using System.Windows.Media.Composition;

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Media/Animation/Generated/ColorIndependentAnimationStorage.cs

@@ -22,7 +22,6 @@
 using System.Windows.Media.Composition;
 using System.Windows.Media.Media3D;
 using System.Security;
-using System.Security.Permissions;
 
 namespace System.Windows.Media.Animation
 {

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Media/Animation/Generated/DoubleIndependentAnimationStorage.cs

@@ -22,7 +22,6 @@
 using System.Windows.Media.Composition;
 using System.Windows.Media.Media3D;
 using System.Security;
-using System.Security.Permissions;
 
 namespace System.Windows.Media.Animation
 {

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Media/Animation/Generated/MatrixIndependentAnimationStorage.cs

@@ -22,7 +22,6 @@
 using System.Windows.Media.Composition;
 using System.Windows.Media.Media3D;
 using System.Security;
-using System.Security.Permissions;
 
 namespace System.Windows.Media.Animation
 {

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Media/Animation/Generated/ParallelTimeline.cs

@@ -33,7 +33,6 @@
 using System.Windows.Markup;
 using System.Windows.Media.Converters;
 using System.Security;
-using System.Security.Permissions;
 using SR=MS.Internal.PresentationCore.SR;
 using SRID=MS.Internal.PresentationCore.SRID;
 // These types are aliased to match the unamanaged names used in interop

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Media/Animation/Generated/Point3DIndependentAnimationStorage.cs

@@ -22,7 +22,6 @@
 using System.Windows.Media.Composition;
 using System.Windows.Media.Media3D;
 using System.Security;
-using System.Security.Permissions;
 
 namespace System.Windows.Media.Animation
 {

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Media/Animation/Generated/PointIndependentAnimationStorage.cs

@@ -22,7 +22,6 @@
 using System.Windows.Media.Composition;
 using System.Windows.Media.Media3D;
 using System.Security;
-using System.Security.Permissions;
 
 namespace System.Windows.Media.Animation
 {

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Media/Animation/Generated/QuaternionIndependentAnimationStorage.cs

@@ -22,7 +22,6 @@
 using System.Windows.Media.Composition;
 using System.Windows.Media.Media3D;
 using System.Security;
-using System.Security.Permissions;
 
 namespace System.Windows.Media.Animation
 {

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Media/Animation/Generated/RectIndependentAnimationStorage.cs

@@ -22,7 +22,6 @@
 using System.Windows.Media.Composition;
 using System.Windows.Media.Media3D;
 using System.Security;
-using System.Security.Permissions;
 
 namespace System.Windows.Media.Animation
 {

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Media/Animation/Generated/SizeIndependentAnimationStorage.cs

@@ -22,7 +22,6 @@
 using System.Windows.Media.Composition;
 using System.Windows.Media.Media3D;
 using System.Security;
-using System.Security.Permissions;
 
 namespace System.Windows.Media.Animation
 {

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Media/Animation/Generated/Timeline.cs

@@ -33,7 +33,6 @@
 using System.Windows.Markup;
 using System.Windows.Media.Converters;
 using System.Security;
-using System.Security.Permissions;
 using SR=MS.Internal.PresentationCore.SR;
 using SRID=MS.Internal.PresentationCore.SRID;
 // These types are aliased to match the unamanaged names used in interop

src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Media/Animation/Generated/TimelineCollection.cs

@@ -33,7 +33,6 @@
 using System.Windows.Markup;
 using System.Windows.Media.Converters;
 using System.Security;
-using System.Security.Permissions;
 using SR=MS.Internal.PresentationCore.SR;
 using SRID=MS.Internal.PresentationCore.SRID;
 // These types are aliased to match the unamanaged names used in interop