Skip to content

Cleanup System.Security.Permissions using directives and more comments #1272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 16, 2019
Merged

Cleanup System.Security.Permissions using directives and more comments #1272

merged 2 commits into from
Jul 16, 2019

Conversation

ojhad
Copy link
Contributor

@ojhad ojhad commented Jul 15, 2019

Issue #1108
Cleaned up System.Security.Permissions using directives and more permission related comments.
Also removed the PackageReference to System.Security.Permissions from the TestProjects.targets file

Ran full DRT pass and verified that everything is at baseline

@ghost ghost requested review from vatsan-madhavan, rladuca, ryalanms and stevenbrix July 15, 2019 14:52
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Jul 15, 2019
@ghost ghost requested a review from SamBent July 15, 2019 14:52
vatsan-madhavan
vatsan-madhavan approved these changes Jul 16, 2019
View reviewed changes
Copy link
Member

@vatsan-madhavan vatsan-madhavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ojhad ojhad merged commit 52f24ad into master Jul 16, 2019
@vatsan-madhavan vatsan-madhavan deleted the user/ojhad/removeleftoverpermissionscode branch August 23, 2019 20:12
@ghost ghost locked as resolved and limited conversation to collaborators Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vatsan-madhavan vatsan-madhavan vatsan-madhavan approved these changes

@rladuca rladuca Awaiting requested review from rladuca

@ryalanms ryalanms Awaiting requested review from ryalanms

@stevenbrix stevenbrix Awaiting requested review from stevenbrix

@SamBent SamBent Awaiting requested review from SamBent

Assignees
No one assigned
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ojhad @vatsan-madhavan