-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Microsoft.NET.Sdk.WindowsDesktop.props references System.Windows.Controls.Ribbon on .NET 4.0 #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Same issue with |
We are beginning to multi-target our WPF control assemblies to net40 and netcoreapp3.0 and are running into this warning now all over the place:
This was originally reported in January and is still occurring in .NET 3.0 preview5. Will it be fixed soon? |
We should definitely fix this before p7. I worry that this will continue to be a big problem for several mainstream scenarios. This is either related to or a duplicate of #327. /cc @nguerrera, @grubioe, @rladuca |
…priate when targeting net3x and net40 Fixes #255
…priate when targeting net3x and net40 Fixes #255
…priate when targeting net3x and net40 (#881) * Ensure that implicit references for .NET Framework projects are appropriate when targeting net3x and net40 Fixes #255 * Use $(_TargetFrameworkVersionWithoutV) for exact comparisons. * Add `$(_MicrosoftNetSdkWindowsDesktop)` . This can be used later in `Microsoft.NET.Sdk` to test whether properties like `UseWpf` or `UseWindowsForms` are set without import `Microsoft.NET.Sdk.WindowsDesktop` and show a warning.
Problem description:
When targeting net40 from a WPF app the build emits a warning.
Actual behavior:
Warning:
Expected behavior:
No warning
Minimal repro:
dotnet new wpf
change targetframework to
net40
or make it cross-target.dotnet build
(project also attached)
net40.zip
I believe the fix is here is to put a condition on the _SDKImplicitReference items defined in Microsoft.NET.Sdk.WindowsDesktop.props.
Originally reported here: dotnet/core#2085 (comment)
The text was updated successfully, but these errors were encountered: