Skip to content

Fluent2 ListBoxItem Style Doesn't Match Windows 11 #9563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
robert-abeo opened this issue Aug 13, 2024 · 2 comments
Closed

Fluent2 ListBoxItem Style Doesn't Match Windows 11 #9563

robert-abeo opened this issue Aug 13, 2024 · 2 comments

Comments

@robert-abeo
Copy link

Description

Fluent v1 had no Pill selection indicators. So the whole background was highlighted when an item was selected usually a blue color. When Fluent v2 was released publicly first in the WinUI repository they didn't include the updated "Pill" selection indicator design for ListBox. It kept the old styles (probably for compatibility) for ListBox but they did update controls like ComboBox and ListView. However, Fluent v2 released in Windows 11 had it most places. But they sometimes use is differently based on controls... in the WinUI 3 [control] Gallery:

ListBox [WinUI 3 Gallery]
image

ListView [WinUI 3 Gallery]
image

Simply put ListView is the correct Fluent v2 Style and it should be the default for ListBox as well.

Reproduction Steps

See current Fluent theme

Expected behavior

Style significantly differs between ListBox and ListView. It needs to be discussed what the default needs to be: Pill or no Pill. And then we also need to have separate "Pill" styles available as well. So we should perhaps have PillListBoxItem or AlternateListBoxItem keyed resource (assuming it isn't the default).

However, I expect we should have the ListView style for ListBox as well since this is representative of Fluent2 design intent.

image

Actual behavior

image

Regression?

No response

Known Workarounds

Fluent Theme

Impact

No response

Configuration

No response

Other information

No response

@dipeshmsft
Copy link
Member

@robert-abeo , we had this discussion with the WinUI team earlier as well, and the current styles for ListBox and ListView was decided to keep it in parity with WinUI.

@dipeshmsft dipeshmsft self-assigned this Feb 12, 2025
@robert-abeo
Copy link
Author

Personally, I'm not a fan of having two different styles for very similar controls like this. However, if that's the WinUI design team's direction it is what it is. I'll close it because:

  1. It is current WinUI design intent
  2. It matches current upstream WinUI code as well
  3. It allows the ListBox more compatibility with existing applications (Aero2)

@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: ☑ Done
Development

No branches or pull requests

3 participants