Fluent2 Using Old/Incorrect ResourceKeys (Example ToolTip)

[robert-abeo]

Description

If you look at upstream WinUI3 you will see it's using ToolTipForegroundBrush and other resources WITH the Brush suffix.

https://github.com/microsoft/microsoft-ui-xaml/blob/aeed4c19e2fc7c2c093216a51b651f2f0890c930/src/controls/dev/CommonStyles/ToolTip_themeresources.xaml#L43-L44

However, here in WPF, we are using the OLD resource name/key that was replaced.

wpf/src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/ToolTip.xaml

Lines 17 to 18 in cc2eee2

	<Setter Property="Foreground" Value="{DynamicResource ToolTipForeground}" />
	<Setter Property="Background" Value="{DynamicResource ToolTipBackground}" />

(Note WinUI3 keeps the old resource keys only for compatibility; but we shouldn't release with the old keys).

Resource keys are one of, if not the most important reason, WPF's Fluent2 theme should have been based on upstream code directly from the start (the open source library you based off was already out-of-date and wasn't a clean port to begin with). We are going to find issues with the control templates as well but those can be changed somewhat after the fact. Keys are locked.

Please, devote the manpower to review all resources and re-align with upstream. ToolTip here is only an example.

Reproduction Steps

Just review the styles

Expected behavior

I believe the Brush and Color suffixes are the current standard for resources like this. (The vast majority of other resources also end with the type name Thickness, etc.)

Actual behavior

Wrong resource keys

Regression?

No response

Known Workarounds

No response

Impact

No response

Configuration

No response

Other information

No response

[dipeshmsft]

@robert-abeo this doesn't seem in sync with the other styles. In rest of the places there is no suffix for Background or Foreground brushes. I am inclined to keep it this way