Skip to content

Add fluent usage documentation #10051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 22, 2025
Merged

Conversation

dipeshmsft
Copy link
Member

@dipeshmsft dipeshmsft commented Nov 11, 2024

Microsoft Reviewers: Open in CodeFlow

@dipeshmsft dipeshmsft requested review from a team as code owners November 11, 2024 13:14
@dotnet-policy-service dotnet-policy-service bot added the PR metadata: Label to tag PRs, to facilitate with triage label Nov 11, 2024
@miloush
Copy link
Contributor

miloush commented Nov 11, 2024

I think it needs to be more prominently written that this is all experimental for testing purposes and might not work the same in the final release of the theming.

This specifically includes the idea of merging in a dictionary, thus all the resource keys and the way they are referenced.

Copy link
Member

@singhashish-wpf singhashish-wpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dipeshmsft
Copy link
Member Author

I think it needs to be more prominently written that this is all experimental for testing purposes and might not work the same in the final release of the theming.

I have added a note at the top of the doc saying that the fluent theme is in experimental stage and will evolve further.

@dipeshmsft dipeshmsft merged commit 6c883e9 into main Jan 22, 2025
2 checks passed
@dipeshmsft dipeshmsft deleted the add-fluent-usage-documentation branch January 22, 2025 11:09
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR metadata: Label to tag PRs, to facilitate with triage Win 11 Theming
Projects
Status: ☑ Done
Development

Successfully merging this pull request may close these issues.

5 participants